Don't show unresolved toggle when unauthenticated

Bug: Issue 8532
Change-Id: Ibd9c1205ddbc7634fd05b2805b540716ca5d1f41
This commit is contained in:
Becky Siegel
2018-03-15 14:20:11 -07:00
parent 3591eca459
commit d665a7aa4f
4 changed files with 21 additions and 1 deletions

View File

@@ -576,6 +576,7 @@ limitations under the License.
change="[[_change]]"
change-num="[[_changeNum]]"
class$="[[_computeShowThreads(_showMessagesView)]]"
logged-in="[[_loggedIn]]"
on-thread-list-modified="_handleReloadDiffComments"></gr-thread-list>
</div>
<gr-overlay id="downloadOverlay" with-backdrop>

View File

@@ -42,6 +42,12 @@ limitations under the License.
min-height: 3.2em;
padding: .5em var(--default-horizontal-margin);
}
.toggleItem.draftToggle {
display: none;
}
.toggleItem.draftToggle.show {
display: flex;
}
.toggleItem {
align-items: center;
display: flex;
@@ -63,7 +69,7 @@ limitations under the License.
id="unresolvedToggle"
on-change="_toggleUnresolved"></paper-toggle-button>
Only unresolved threads</div>
<div class="toggleItem">
<div class$="toggleItem draftToggle [[_computeShowDraftToggle(loggedIn)]]">
<paper-toggle-button
id="draftToggle"
on-change="_toggleDrafts"></paper-toggle-button>

View File

@@ -28,12 +28,17 @@
change: Object,
threads: Array,
changeNum: String,
loggedIn: Boolean,
_sortedThreads: {
type: Array,
computed: '_computeSortedThreads(threads.*)',
},
},
_computeShowDraftToggle(loggedIn) {
return loggedIn ? 'show' : '';
},
/**
* Order as follows:
* - Unresolved threads with drafts (reverse chronological)

View File

@@ -186,6 +186,14 @@ limitations under the License.
sandbox.restore();
});
test('draft toggle only appears when logged in', () => {
assert.equal(getComputedStyle(element.$$('.draftToggle')).display,
'none');
element.loggedIn = true;
assert.notEqual(getComputedStyle(element.$$('.draftToggle')).display,
'none');
});
test('there are five threads by default', () => {
assert.equal(computeVisibleNumber(threadElements), 5);
});