opendev/gerrit
Code Issues Proposed changes

Delete unused (and broke) ListChangesOption.fromValue() method

Browse Source 
This method does not work when the enum values are ordered
differently from the value passed in the construct. Since its
unused, just delete it. Nobody needs it so there is no value
in trying to fix the code.

Change-Id: I381bac6e54156813b127dfda36024b0297966dc1
This commit is contained in:
Shawn Pearce
2013-03-05 16:22:32 -08:00
parent 3e22d48084
commit d669bda1de
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-common/src/main/java/com/google/gerrit/common/changes/ListChangesOption.java
View File

@@ -46,10 +46,6 @@ public enum ListChangesOption {
return value;
}
public static ListChangesOption fromValue(int value) {
return ListChangesOption.values()[value];
}
public static EnumSet<ListChangesOption> fromBits(int v) {
EnumSet<ListChangesOption> r = EnumSet.noneOf(ListChangesOption.class);
for (ListChangesOption o : ListChangesOption.values()) {