opendev/gerrit
Code Issues Proposed changes

Merge "ChangeInfo#getMissingLabelIndex(): return correct index"

Browse Source
This commit is contained in:
Dave Borowitz
2015-04-20 22:21:44 +00:00
committed by Gerrit Code Review
parent ebe27a4163 96f72ee95f
commit d6830d1978
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java
View File

@@ -149,10 +149,11 @@ public class ChangeInfo extends JavaScriptObject {
* if no label is missing, or if more than one label is missing. * if no label is missing, or if more than one label is missing.
*/ */
public final int getMissingLabelIndex() { public final int getMissingLabelIndex() {
int i = 0; int i = -1;
int ret = -1; int ret = -1;
List<LabelInfo> labels = Natives.asList(all_labels().values()); List<LabelInfo> labels = Natives.asList(all_labels().values());
for (LabelInfo label : labels) { for (LabelInfo label : labels) {
i++;
if (!permitted_labels().containsKey(label.name())) { if (!permitted_labels().containsKey(label.name())) {
continue; continue;
} }
@@ -183,7 +184,6 @@ public class ChangeInfo extends JavaScriptObject {
set_submittable(false); set_submittable(false);
return -1; return -1;
} }
i++;
} }
set_submittable(ret == -1); set_submittable(ret == -1);
return ret; return ret;