opendev/gerrit
Code Issues Proposed changes

HttpPluginServlet: Don't use default platform charset in InputStreamReader

Browse Source 
Reported by Error Prone 2.0.15.

Change-Id: Idd3f3bdf523689f57b1bbdf4be6905c57f1b6793
This commit is contained in:
David Pursehouse
2016-12-12 09:39:06 +09:00
parent 3bb12802a7
commit d6b831da3a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/HttpPluginServlet.java
View File

@@ -433,7 +433,8 @@ class HttpPluginServlet extends HttpServlet
appendPluginInfoTable(md, scanner.getManifest().getMainAttributes()); appendPluginInfoTable(md, scanner.getManifest().getMainAttributes());
if (about != null) { if (about != null) {
InputStreamReader isr = new InputStreamReader(scanner.getInputStream(about)); InputStreamReader isr = new InputStreamReader(
scanner.getInputStream(about), UTF_8);
StringBuilder aboutContent = new StringBuilder(); StringBuilder aboutContent = new StringBuilder();
try (BufferedReader reader = new BufferedReader(isr)) { try (BufferedReader reader = new BufferedReader(isr)) {
String line; String line;