opendev/gerrit
Code Issues Proposed changes

Remove redundant 'public' modifiers

Browse Source 
CheckStyle reports 'public' being redundant on the constructor of
ApproveOption#Handler, but removing it causes test failures due to
org.kohsuke.args4j.Option requiring an explicitly public constructor.

Add a suppression for that one, and remove the 'public' in other
places where it's reported.

Change-Id: Ifbcf279ffa783d33b81efc1c675f468c3ea39135
This commit is contained in:
David Pursehouse
2016-04-12 11:02:47 +09:00
parent e7996de77f
commit d79c03a7f6
27 changed files with 31 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/change/Move.java
View File

@@ -108,7 +108,7 @@ public class Move implements RestModifyView<ChangeResource, MoveInput> {
private Change change;
private Branch.NameKey newDestKey;
public Op(ChangeControl ctl, MoveInput input) {
Op(ChangeControl ctl, MoveInput input) {
this.input = input;
this.caller = ctl.getUser().asIdentifiedUser();
}

2
gerrit-server/src/main/java/com/google/gerrit/server/change/PutTopic.java
View File

@@ -90,7 +90,7 @@ public class PutTopic implements RestModifyView<ChangeResource, Input>,
private String oldTopicName;
private String newTopicName;
public Op(Input input) {
Op(Input input) {
this.input = input;
}

4
gerrit-server/src/main/java/com/google/gerrit/server/change/Revert.java
View File

@@ -214,7 +214,7 @@ public class Revert implements RestModifyView<ChangeResource, RevertInput>,
private class SendEmailOp extends BatchUpdate.Op {
private final ChangeInserter ins;
public SendEmailOp(ChangeInserter ins) {
SendEmailOp(ChangeInserter ins) {
this.ins = ins;
}
@@ -236,7 +236,7 @@ public class Revert implements RestModifyView<ChangeResource, RevertInput>,
private class PostRevertedMessageOp extends BatchUpdate.Op {
private final ObjectId computedChangeId;
public PostRevertedMessageOp(ObjectId computedChangeId) {
PostRevertedMessageOp(ObjectId computedChangeId) {
this.computedChangeId = computedChangeId;
}

2
gerrit-server/src/main/java/com/google/gerrit/server/group/DbGroupMemberAuditListener.java
View File

@@ -49,7 +49,7 @@ class DbGroupMemberAuditListener implements GroupMemberAuditListener {
private final UniversalGroupBackend groupBackend;
@Inject
public DbGroupMemberAuditListener(SchemaFactory<ReviewDb> schema,
DbGroupMemberAuditListener(SchemaFactory<ReviewDb> schema,
AccountCache accountCache, GroupCache groupCache,
UniversalGroupBackend groupBackend) {
this.schema = schema;

2
gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java
View File

@@ -259,7 +259,7 @@ public class CreateBranch implements RestModifyView<ProjectResource, Input> {
public static final String MESSAGE = "Invalid Revision";
public InvalidRevisionException() {
InvalidRevisionException() {
super(MESSAGE);
}
}

2
gerrit-server/src/main/java/com/google/gerrit/server/project/RepositoryStatistics.java
View File

@@ -23,7 +23,7 @@ import java.util.TreeMap;
class RepositoryStatistics extends TreeMap<String, Object> {
private static final long serialVersionUID = 1L;
public RepositoryStatistics(Properties p) {
RepositoryStatistics(Properties p) {
for (Entry<Object, Object> e : p.entrySet()) {
put(CaseFormat.LOWER_CAMEL.to(CaseFormat.LOWER_UNDERSCORE,
e.getKey().toString()), e.getValue());

2
gerrit-server/src/main/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java
View File

@@ -83,7 +83,7 @@ public class SubmitRuleEvaluator {
private static class UserTermExpected extends Exception {
private static final long serialVersionUID = 1L;
public UserTermExpected(SubmitRecord.Label label) {
UserTermExpected(SubmitRecord.Label label) {
super(String.format("A label with the status %s must contain a user.",
label.toString()));
}

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/HANA.java
View File

@@ -30,7 +30,7 @@ class HANA extends BaseDataSourceType {
private Config cfg;
@Inject
public HANA(@GerritServerConfig final Config cfg) {
HANA(@GerritServerConfig final Config cfg) {
super("com.sap.db.jdbc.Driver");
this.cfg = cfg;
}

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/MaxDb.java
View File

@@ -29,7 +29,7 @@ class MaxDb extends BaseDataSourceType {
private Config cfg;
@Inject
public MaxDb(@GerritServerConfig final Config cfg) {
MaxDb(@GerritServerConfig final Config cfg) {
super("com.sap.dbtech.jdbc.DriverSapDB");
this.cfg = cfg;
}

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java
View File

@@ -28,7 +28,7 @@ class MySql extends BaseDataSourceType {
private Config cfg;
@Inject
public MySql(@GerritServerConfig final Config cfg) {
MySql(@GerritServerConfig final Config cfg) {
super("com.mysql.jdbc.Driver");
this.cfg = cfg;
}

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/PostgreSQL.java
View File

@@ -30,7 +30,7 @@ class PostgreSQL extends BaseDataSourceType {
private Config cfg;
@Inject
public PostgreSQL(@GerritServerConfig final Config cfg) {
PostgreSQL(@GerritServerConfig final Config cfg) {
super("org.postgresql.Driver");
this.cfg = cfg;
}