opendev/gerrit
Code Issues Proposed changes

Remove redundant 'public' modifiers

Browse Source 
CheckStyle reports 'public' being redundant on the constructor of
ApproveOption#Handler, but removing it causes test failures due to
org.kohsuke.args4j.Option requiring an explicitly public constructor.

Add a suppression for that one, and remove the 'public' in other
places where it's reported.

Change-Id: Ifbcf279ffa783d33b81efc1c675f468c3ea39135
This commit is contained in:
David Pursehouse
2016-04-12 11:02:47 +09:00
parent e7996de77f
commit d79c03a7f6
27 changed files with 31 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/HANA.java
View File

@@ -30,7 +30,7 @@ class HANA extends BaseDataSourceType {
private Config cfg;
@Inject
public HANA(@GerritServerConfig final Config cfg) {
HANA(@GerritServerConfig final Config cfg) {
super("com.sap.db.jdbc.Driver");
this.cfg = cfg;
}

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/MaxDb.java
View File

@@ -29,7 +29,7 @@ class MaxDb extends BaseDataSourceType {
private Config cfg;
@Inject
public MaxDb(@GerritServerConfig final Config cfg) {
MaxDb(@GerritServerConfig final Config cfg) {
super("com.sap.dbtech.jdbc.DriverSapDB");
this.cfg = cfg;
}

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/MySql.java
View File

@@ -28,7 +28,7 @@ class MySql extends BaseDataSourceType {
private Config cfg;
@Inject
public MySql(@GerritServerConfig final Config cfg) {
MySql(@GerritServerConfig final Config cfg) {
super("com.mysql.jdbc.Driver");
this.cfg = cfg;
}

2
gerrit-server/src/main/java/com/google/gerrit/server/schema/PostgreSQL.java
View File

@@ -30,7 +30,7 @@ class PostgreSQL extends BaseDataSourceType {
private Config cfg;
@Inject
public PostgreSQL(@GerritServerConfig final Config cfg) {
PostgreSQL(@GerritServerConfig final Config cfg) {
super("org.postgresql.Driver");
this.cfg = cfg;
}