From 882d3bc2cca0b1ebeca65276d163e14b2a32f39e Mon Sep 17 00:00:00 2001 From: Christian Aistleitner Date: Mon, 4 Mar 2013 09:49:34 +0100 Subject: [PATCH] Upon selection in AddMemberBox, focus the box's text field In the change screen, after clicking on an element of the 'Add Reviewer' suggestion list, users expect to be able to add the reviewer by hitting enter. This did not work in Firefox, as after clicking on an entry in the suggestion list, the body got focused. By setting the focus on the 'Add reviewer's text box after selecting a suggestion list item, we now allow users to add the reviewer by hitting enter. Change-Id: I50ab4f80107f606f97260d48fc770672b829ea38 --- .../src/main/java/com/google/gerrit/client/ui/AddMemberBox.java | 1 + 1 file changed, 1 insertion(+) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddMemberBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddMemberBox.java index 72a011fd9d..d4aaa4c78a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddMemberBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/AddMemberBox.java @@ -72,6 +72,7 @@ public class AddMemberBox extends Composite { nameTxt.addSelectionHandler(new SelectionHandler() { @Override public void onSelection(SelectionEvent event) { + nameTxtBox.setFocus(true); if (submitOnSelection) { submitOnSelection = false; doAdd();