opendev/gerrit
Code Issues Proposed changes

Remove unused RPC suggest service

Browse Source 
Change-Id: I2a538f29e81a853786935c3ba07bedbd2733f3b5
This commit is contained in:
David Pursehouse
2016-02-18 16:46:08 +09:00
parent 9f145780c4
commit d8889fe94c
4 changed files with 0 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
gerrit-common/src/main/java/com/google/gerrit/common/data/SuggestService.java
View File

@@ -1,29 +0,0 @@
// Copyright (C) 2008 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.common.data;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.gwtjsonrpc.common.RemoteJsonService;
import com.google.gwtjsonrpc.common.RpcImpl;
import com.google.gwtjsonrpc.common.RpcImpl.Version;
import java.util.List;
@RpcImpl(version = Version.V2_0)
public interface SuggestService extends RemoteJsonService {
void suggestAccountGroupForProject(Project.NameKey project, String query,
int limit, AsyncCallback<List<GroupReference>> callback);
}

31
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/SuggestUtil.java
View File

@@ -1,31 +0,0 @@
// Copyright (C) 2008 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.client.ui;
import com.google.gerrit.common.data.SuggestService;
import com.google.gwt.core.client.GWT;
import com.google.gwtjsonrpc.client.JsonUtil;
public class SuggestUtil {
public static final SuggestService SVC;
static {
SVC = GWT.create(SuggestService.class);
JsonUtil.bind(SVC, "rpc/SuggestService");
}
private SuggestUtil() {
}
}

76
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SuggestServiceImpl.java
View File

@@ -1,76 +0,0 @@
// Copyright (C) 2008 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.httpd.rpc;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.gerrit.common.Nullable;
import com.google.gerrit.common.data.GroupReference;
import com.google.gerrit.common.data.SuggestService;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.account.GroupBackend;
import com.google.gerrit.server.project.NoSuchProjectException;
import com.google.gerrit.server.project.ProjectControl;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.inject.Inject;
import com.google.inject.Provider;
import java.util.Collections;
import java.util.List;
class SuggestServiceImpl extends BaseServiceImplementation implements
SuggestService {
private final ProjectControl.Factory projectControlFactory;
private final GroupBackend groupBackend;
@Inject
SuggestServiceImpl(final Provider<ReviewDb> schema,
final Provider<CurrentUser> currentUser,
final ProjectControl.Factory projectControlFactory,
final GroupBackend groupBackend) {
super(schema, currentUser);
this.projectControlFactory = projectControlFactory;
this.groupBackend = groupBackend;
}
@Override
public void suggestAccountGroupForProject(final Project.NameKey project,
final String query, final int limit,
final AsyncCallback<List<GroupReference>> callback) {
run(callback, new Action<List<GroupReference>>() {
@Override
public List<GroupReference> run(final ReviewDb db) {
ProjectControl projectControl = null;
if (project != null) {
try {
projectControl = projectControlFactory.controlFor(project);
} catch (NoSuchProjectException e) {
return Collections.emptyList();
}
}
return suggestAccountGroup(projectControl, query, limit);
}
});
}
private List<GroupReference> suggestAccountGroup(
@Nullable final ProjectControl projectControl, final String query, final int limit) {
return Lists.newArrayList(Iterables.limit(
groupBackend.suggest(query, projectControl),
limit <= 0 ? 10 : Math.min(limit, 10)));
}
}

1
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/UiRpcModule.java
View File

@@ -27,7 +27,6 @@ public class UiRpcModule extends RpcServletModule {
@Override @Override
protected void configureServlets() { protected void configureServlets() {
rpc(SuggestServiceImpl.class);
rpc(SystemInfoServiceImpl.class); rpc(SystemInfoServiceImpl.class);
install(new AccountModule()); install(new AccountModule());