opendev/gerrit
Code Issues Proposed changes

download-commands: rename REPO_DOWNLOAD to REPO

Browse Source 
The "download" suffix is redundant and reflects how `repo` used to
be used in the download plugin -- as kind of a pseudo download
bolted onto the side.  Since we've reworked the plugin, we can
rename this constant to better reflect its usage.

We have to duplicate it here since the download-commands plugin is
using this.  Once that migrates, we can delete the old name.

Change-Id: I948c7f2f427dec64c2617f834a5f7b35e7179543
This commit is contained in:
Mike Frysinger
2020-07-22 03:02:30 -04:00
parent 4fdffd4b29
commit d8be895424
2 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/entities/CoreDownloadSchemes.java
View File

@@ -21,6 +21,7 @@ public class CoreDownloadSchemes {
public static final String HTTP = "http"; public static final String HTTP = "http";
public static final String SSH = "ssh"; public static final String SSH = "ssh";
public static final String REPO_DOWNLOAD = "repo"; public static final String REPO_DOWNLOAD = "repo";
public static final String REPO = "repo";
private CoreDownloadSchemes() {} private CoreDownloadSchemes() {}
} }

1
java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java
View File

@@ -27,7 +27,6 @@ public class GeneralPreferencesInfo {
/** Preferred method to download a change. */ /** Preferred method to download a change. */
public enum DownloadCommand { public enum DownloadCommand {
REPO_DOWNLOAD,
PULL, PULL,
CHECKOUT, CHECKOUT,
CHERRY_PICK, CHERRY_PICK,