opendev/gerrit
Code Issues Proposed changes

Remove the 'Change SHA1:' from the PatchScreen title

Browse Source 
This extra info in the title is not useful so removing
it makes the PatchScreen less cluttered by default.

Change-Id: Ib760287410e718eb023005c13a456d875b9e5edc
This commit is contained in:
Martin Fick
2011-06-10 11:31:11 -06:00
parent f13b8ab3ff
commit d8d842afa6
3 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchMessages.java
View File

@@ -19,8 +19,6 @@ import com.google.gwt.i18n.client.Messages;
import java.util.Date; import java.util.Date;
public interface PatchMessages extends Messages { public interface PatchMessages extends Messages {
String patchWindowTitle(String changeId, String file);
String patchPageTitle(String changeId, String path);
String patchSkipRegion(@PluralCount int lineCnt); String patchSkipRegion(@PluralCount int lineCnt);
String draftSaved(Date when); String draftSaved(Date when);
} }

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchMessages.properties
View File

@@ -1,6 +1,3 @@
patchWindowTitle = Change {0}: {1}
patchPageTitle = Change {0}: {1}
patchSkipRegion = (... skipping {0} common lines ...) patchSkipRegion = (... skipping {0} common lines ...)
draftSaved = Draft saved at {0,time,short} draftSaved = Draft saved at {0,time,short}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java
View File

@@ -395,8 +395,8 @@ public abstract class PatchScreen extends Screen implements
fileName = fileName.substring(last + 1); fileName = fileName.substring(last + 1);
} }
setWindowTitle(PatchUtil.M.patchWindowTitle(cid.abbreviate(), fileName)); setWindowTitle(fileName);
setPageTitle(PatchUtil.M.patchPageTitle(cid.abbreviate(), path)); setPageTitle(path);
if (idSideB.equals(patchSetDetail.getPatchSet().getId())) { if (idSideB.equals(patchSetDetail.getPatchSet().getId())) {
commitMessageBlock.setVisible(true); commitMessageBlock.setVisible(true);