opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-3.1'

Browse Source 
* stable-3.1:
  Fix ChangeIT#changeDetailsDoesNotRequireIndex
  Fix plugin documentation link for checks plugin
  CreateGroupPermissionSyncer: Fix malformed Javadoc

Change-Id: Ic9a82be245129328f6c866d6659be18d305355b9
This commit is contained in:
David Pursehouse 2019-10-30 16:03:19 +09:00
commit d8e0e67ae7
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/config-plugins.txt
View File

@ -276,8 +276,8 @@ CI systems with Gerrit.
link:https://gerrit-review.googlesource.com/admin/repos/plugins/checks[
Project] |
link:https://gerrit.googlesource.com/plugins/checks/+doc/master/src/main/resources/Documentation/about.md[
Plugin Documentation]]
link:https://gerrit.googlesource.com/plugins/checks/+doc/master/README.md[
Plugin Documentation]
[[egit]]
=== egit

2
java/com/google/gerrit/server/CreateGroupPermissionSyncer.java
View File

@ -45,7 +45,7 @@ import org.eclipse.jgit.errors.ConfigInvalidException;
* <p>During the transition phase, we have to keep these permissions in sync with the global
* capabilities that serve as the source of truth.
*
* <p><This class implements a one-way synchronization from the global {@code CREATE_GROUP}
* <p>This class implements a one-way synchronization from the global {@code CREATE_GROUP}
* capability in {@code All-Projects} to a {@code CREATE} permission on {@code refs/groups/*} in
* {@code All-Users}.
*/

4
javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java
View File

@ -4375,10 +4375,10 @@ public class ChangeIT extends AbstractDaemonTest {
ListChangesOption.SKIP_DIFFSTAT);
PushOneCommit.Result change = createChange();
int number = gApi.changes().id(change.getChangeId()).get(options)._number;
int number = gApi.changes().id(change.getChangeId()).get()._number;
try (AutoCloseable ignored = disableChangeIndex()) {
assertThat(gApi.changes().id(project.get(), number).get().changeId)
assertThat(gApi.changes().id(project.get(), number).get(options).changeId)
.isEqualTo(change.getChangeId());
}
}