opendev/gerrit
Code Issues Proposed changes

Use monospace font when editing commit message

Browse Source 
Layout matters on a commit message, because tools don't line wrap
automatically. Use a monospaced font like we do at display time so
the lines in the editor line up correctly.

Update the width to be 72 characters in the monospaced font, to
encourage authors to keep the width of a message within the confines
of an 80 column terminal after git log adds its formatting.

Change-Id: I8563e666602316a73b0f43eb37e353791e04fbb2
This commit is contained in:
Shawn O. Pearce
2012-11-25 21:05:48 -08:00
committed by David Pursehouse
parent 8e21b9e5be
commit d90d9bda1d
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommitMessageBlock.java
View File

@@ -21,8 +21,6 @@ import com.google.gerrit.client.ui.CommentedActionDialog;
import com.google.gerrit.common.data.ChangeDetail;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.core.client.GWT;
import com.google.gwt.dom.client.PreElement;
import com.google.gwt.dom.client.Style.Display;
@@ -30,6 +28,7 @@ import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.uibinder.client.UiBinder;
import com.google.gwt.uibinder.client.UiField;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.HTMLPanel;
import com.google.gwt.user.client.ui.Image;
@@ -98,9 +97,11 @@ public class CommitMessageBlock extends Composite {
.titleEditCommitMessage(), Util.C.headingEditCommitMessage(),
new ChangeDetailCache.IgnoreErrorCallback() {}) {
{
message.setCharacterWidth(80);
message.setCharacterWidth(72);
message.setVisibleLines(20);
message.setText(commitMessage);
message.addStyleName(Gerrit.RESOURCES.css()
.changeScreenDescription());
}
@Override