opendev/gerrit
Code Issues Proposed changes

Make the group caches unlimited by default

Browse Source 
The group caches should be large enough to hold entries for all internal
groups otherwise overall Gerrit performance may be poor. Make the group
caches unlimited by default and add a note to the documentation.

Change-Id: Ieef38b9dda71bf8c7174c1030e069037721f38c8
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-11-13 15:14:41 +01:00
parent 3091e11e35
commit d967ec4aa9
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/com/google/gerrit/server/account/GroupCacheImpl.java
View File

@@ -52,12 +52,15 @@ public class GroupCacheImpl implements GroupCache {
@Override
protected void configure() {
cache(BYID_NAME, AccountGroup.Id.class, new TypeLiteral<Optional<InternalGroup>>() {})
.maximumWeight(Long.MAX_VALUE)
.loader(ByIdLoader.class);
cache(BYNAME_NAME, String.class, new TypeLiteral<Optional<InternalGroup>>() {})
.maximumWeight(Long.MAX_VALUE)
.loader(ByNameLoader.class);
cache(BYUUID_NAME, String.class, new TypeLiteral<Optional<InternalGroup>>() {})
.maximumWeight(Long.MAX_VALUE)
.loader(ByUUIDLoader.class);
bind(GroupCacheImpl.class);