Buck: Fix java_doc rule to use $(classpath :foo) macro
java_doc rule was using $(location :foo) instead of $(classpath :foo) macro. This is similar but not the same. The subtle difference is the replacement that is done for java_library() when only exported deps are used. While location macro doesn't work here, because there are no out file associated with such a java_library, classpath macro correctly resolves the dependencies. Change-Id: Iab67dff9c332027765bc0da8c46810de11974de8
This commit is contained in:
parent
5e3fc571e2
commit
d9cafb7ca2
@ -85,8 +85,8 @@ java_doc(
|
|||||||
'//lib/guice:guice-servlet',
|
'//lib/guice:guice-servlet',
|
||||||
'//lib/guice:javax-inject',
|
'//lib/guice:javax-inject',
|
||||||
'//lib:gwtorm_client',
|
'//lib:gwtorm_client',
|
||||||
'//lib:junit__jar',
|
'//lib:junit',
|
||||||
'//lib:truth__jar',
|
'//lib:truth',
|
||||||
],
|
],
|
||||||
visibility = ['PUBLIC'],
|
visibility = ['PUBLIC'],
|
||||||
)
|
)
|
||||||
|
@ -29,7 +29,7 @@ def java_doc(
|
|||||||
'-sourcepath ',
|
'-sourcepath ',
|
||||||
':'.join(sourcepath),
|
':'.join(sourcepath),
|
||||||
' -classpath ',
|
' -classpath ',
|
||||||
':'.join(['$(location %s)' % n for n in deps]),
|
':'.join(['$(classpath %s)' % n for n in deps]),
|
||||||
'-d $TMP',
|
'-d $TMP',
|
||||||
]) + ';jar cf $OUT -C $TMP .',
|
]) + ';jar cf $OUT -C $TMP .',
|
||||||
srcs = srcs,
|
srcs = srcs,
|
||||||
|
Loading…
Reference in New Issue
Block a user