opendev/gerrit
Code Issues Proposed changes

Fix file name matching in commit_delta to perform substring matching

Browse Source 
commit_delta predicate was matching the entire file name against the
given regex while other predicates (commit_edits, commit_message_matches)
performed substring matching. It was inconsistent that for commit_delta we
needed to write something like:

  commit_delta('.*\.java')

to match all *.java files, while for commit_edits we needed:

  commit_edits('\.java$', '...').

to match the same set of (Java) files.

Change-Id: Ib3360684d570539522bfad7b8df2d99734e7157e
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>
This commit is contained in:
Sasa Zivkov
2012-08-03 11:01:10 +02:00
parent 2d0831f273
commit d9dacf5161
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/gerrit/PRED_commit_delta_4.java
View File

@@ -110,8 +110,8 @@ public class PRED_commit_delta_4 extends Predicate.P4 {
continue;
}
if (regex.matcher(newName).matches() ||
(oldName != null && regex.matcher(oldName).matches())) {
if (regex.matcher(newName).find() ||
(oldName != null && regex.matcher(oldName).find())) {
SymbolTerm changeSym = getTypeSymbol(changeType);
SymbolTerm newSym = SymbolTerm.create(newName);
SymbolTerm oldSym = Prolog.Nil;