Merge "Remove _computeAccountStatusString from gr-change-list-item"
This commit is contained in:
@@ -160,16 +160,14 @@ limitations under the License.
|
||||
<td class="cell owner"
|
||||
hidden$="[[isColumnHidden('Owner', visibleChangeTableColumns)]]">
|
||||
<gr-account-link
|
||||
account="[[change.owner]]"
|
||||
additional-text="[[_computeAccountStatusString(change.owner)]]"></gr-account-link>
|
||||
account="[[change.owner]]"></gr-account-link>
|
||||
</td>
|
||||
<td class="cell assignee"
|
||||
hidden$="[[isColumnHidden('Assignee', visibleChangeTableColumns)]]">
|
||||
<template is="dom-if" if="[[change.assignee]]">
|
||||
<gr-account-link
|
||||
id="assigneeAccountLink"
|
||||
account="[[change.assignee]]"
|
||||
additional-text="[[_computeAccountStatusString(change.assignee)]]"></gr-account-link>
|
||||
account="[[change.assignee]]"></gr-account-link>
|
||||
</template>
|
||||
<template is="dom-if" if="[[!change.assignee]]">
|
||||
<span class="placeholder">--</span>
|
||||
|
||||
@@ -165,10 +165,6 @@
|
||||
return str;
|
||||
},
|
||||
|
||||
_computeAccountStatusString(account) {
|
||||
return account && account.status ? `(${account.status})` : '';
|
||||
},
|
||||
|
||||
_computeSizeTooltip(change) {
|
||||
if (change.insertions + change.deletions === 0 ||
|
||||
isNaN(change.insertions + change.deletions)) {
|
||||
|
||||
@@ -189,14 +189,6 @@ limitations under the License.
|
||||
};
|
||||
flushAsynchronousOperations();
|
||||
assert.isOk(element.$$('.assignee gr-account-link'));
|
||||
assert.equal(Polymer.dom(element.root)
|
||||
.querySelector('#assigneeAccountLink').additionalText, '(test)');
|
||||
});
|
||||
|
||||
test('_computeAccountStatusString', () => {
|
||||
assert.equal(element._computeAccountStatusString({}), '');
|
||||
assert.equal(element._computeAccountStatusString({status: 'Working'}),
|
||||
'(Working)');
|
||||
});
|
||||
|
||||
test('TShirt sizing tooltip', () => {
|
||||
|
||||
Reference in New Issue
Block a user