Merge "Remove _computeAccountStatusString from gr-change-list-item"

This commit is contained in:
Ben Rohlfs
2019-09-25 15:25:45 +00:00
committed by Gerrit Code Review
3 changed files with 2 additions and 16 deletions

View File

@@ -160,16 +160,14 @@ limitations under the License.
<td class="cell owner"
hidden$="[[isColumnHidden('Owner', visibleChangeTableColumns)]]">
<gr-account-link
account="[[change.owner]]"
additional-text="[[_computeAccountStatusString(change.owner)]]"></gr-account-link>
account="[[change.owner]]"></gr-account-link>
</td>
<td class="cell assignee"
hidden$="[[isColumnHidden('Assignee', visibleChangeTableColumns)]]">
<template is="dom-if" if="[[change.assignee]]">
<gr-account-link
id="assigneeAccountLink"
account="[[change.assignee]]"
additional-text="[[_computeAccountStatusString(change.assignee)]]"></gr-account-link>
account="[[change.assignee]]"></gr-account-link>
</template>
<template is="dom-if" if="[[!change.assignee]]">
<span class="placeholder">--</span>

View File

@@ -165,10 +165,6 @@
return str;
},
_computeAccountStatusString(account) {
return account && account.status ? `(${account.status})` : '';
},
_computeSizeTooltip(change) {
if (change.insertions + change.deletions === 0 ||
isNaN(change.insertions + change.deletions)) {

View File

@@ -189,14 +189,6 @@ limitations under the License.
};
flushAsynchronousOperations();
assert.isOk(element.$$('.assignee gr-account-link'));
assert.equal(Polymer.dom(element.root)
.querySelector('#assigneeAccountLink').additionalText, '(test)');
});
test('_computeAccountStatusString', () => {
assert.equal(element._computeAccountStatusString({}), '');
assert.equal(element._computeAccountStatusString({status: 'Working'}),
'(Working)');
});
test('TShirt sizing tooltip', () => {