opendev/gerrit
Code Issues Proposed changes

Disable 'Create Group' button if group name not entered

Browse Source 
Disable the 'Create Group' button if no group name
was entered and while the RPC to create the group
is running.

Change-Id: Iead29848e9c3eb4497a00b46d9dd77f99aba3921
Signed-off-by: Edwin Kempin <edwin.kempin@gmail.com>
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Edwin Kempin
2010-10-15 10:13:09 +02:00
committed by Shawn O. Pearce
parent 6cc1190d8f
commit da52c7f993
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java
View File

@@ -19,6 +19,7 @@ import com.google.gerrit.client.Gerrit;
import com.google.gerrit.client.rpc.GerritCallback;
import com.google.gerrit.client.rpc.ScreenLoadCallback;
import com.google.gerrit.client.ui.AccountScreen;
import com.google.gerrit.client.ui.OnEditEnabler;
import com.google.gerrit.client.ui.SmallHeading;
import com.google.gerrit.common.PageLinks;
import com.google.gerrit.reviewdb.AccountGroup;
@@ -78,6 +79,7 @@ public class GroupListScreen extends AccountScreen {
fp.add(addTxt);
addNew = new Button(Util.C.buttonCreateGroup());
addNew.setEnabled(false);
addNew.addClickHandler(new ClickHandler() {
@Override
public void onClick(final ClickEvent event) {
@@ -86,6 +88,8 @@ public class GroupListScreen extends AccountScreen {
});
fp.add(addNew);
add(fp);
new OnEditEnabler(addNew, addTxt);
}
@Override
@@ -100,10 +104,17 @@ public class GroupListScreen extends AccountScreen {
return;
}
addNew.setEnabled(false);
Util.GROUP_SVC.createGroup(newName, new GerritCallback<AccountGroup.Id>() {
public void onSuccess(final AccountGroup.Id result) {
History.newItem(Dispatcher.toAccountGroup(result));
}
@Override
public void onFailure(Throwable caught) {
super.onFailure(caught);
addNew.setEnabled(true);
}
});
}
}