opendev/gerrit
Code Issues Proposed changes

Delete unused onSignOut method

Browse Source 
Once upon a time Gerrit performed a sign-out by just deleting the
cookie and updating the DOM to remove signed-in content. This is
not true anymore, the entire page is refreshed to delete any data
that is private to a signed-in account, and to ensure the server
can clear the correct HttpOnly cookies to actually do a sign-out.

Since that behavior change, this onSignOut method is dead code.

Change-Id: I7d7922f3a38fdcd03615866d0d693088660e1a31
This commit is contained in:
Shawn O. Pearce
2012-04-27 17:45:46 -07:00
parent 1eee2c9d8f
commit da8fee1694
2 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java
View File

@@ -117,14 +117,6 @@ public class ChangeScreen extends Screen
this(c.getId()); this(c.getId());
} }
@Override
public void onSignOut() {
super.onSignOut();
if (starChange != null) {
starChange.setVisible(false);
}
}
@Override @Override
protected void onLoad() { protected void onLoad() {
super.onLoad(); super.onLoad();

9
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java
View File

@@ -15,8 +15,6 @@
package com.google.gerrit.client.ui; package com.google.gerrit.client.ui;
import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.Gerrit;
import com.google.gerrit.common.PageLinks;
import com.google.gwt.user.client.History;
import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Grid; import com.google.gwt.user.client.ui.Grid;
import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.HasHorizontalAlignment;
@@ -148,13 +146,6 @@ public abstract class Screen extends View {
return requiresSignIn; return requiresSignIn;
} }
/** Invoked if this screen is the current screen and the user signs out. */
public void onSignOut() {
if (isRequiresSignIn()) {
History.newItem(PageLinks.toChangeQuery("status:open"));
}
}
public void onShowView() { public void onShowView() {
if (windowTitle != null) { if (windowTitle != null) {
Gerrit.setWindowTitle(this, windowTitle); Gerrit.setWindowTitle(this, windowTitle);