opendev/gerrit
Code Issues Proposed changes

shift+r should only be triggered on keyup

Browse Source 
to prevent multiple invocations when users hold the `shift+r`,
also prevent extra invocations on `r` as when you,
loose the shift first then `r:keyup` will trigger the toggle on review

Change-Id: I3c7559863269477e1395a2831c76e47a209c31b1
This commit is contained in:
Tao Zhou 2019-11-21 16:15:30 -08:00
parent 5bb7c0277a
commit db13f975a5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/gr-app-element.js
View File

@ -211,7 +211,7 @@
this.bindShortcut(
this.Shortcut.TOGGLE_CHANGE_STAR, 's:keyup');
this.bindShortcut(
this.Shortcut.REFRESH_CHANGE_LIST, 'shift+r');
this.Shortcut.REFRESH_CHANGE_LIST, 'shift+r:keyup');
this.bindShortcut(
this.Shortcut.EDIT_TOPIC, 't');
@ -224,7 +224,7 @@
this.bindShortcut(
this.Shortcut.COLLAPSE_ALL_MESSAGES, 'z');
this.bindShortcut(
this.Shortcut.REFRESH_CHANGE, 'shift+r');
this.Shortcut.REFRESH_CHANGE, 'shift+r:keyup');
this.bindShortcut(
this.Shortcut.UP_TO_DASHBOARD, 'u');
this.bindShortcut(