opendev/gerrit
Code Issues Proposed changes

Remove styles for markdown syntax

Browse Source 
Support for markdown files would only typeset text as bold or italic
when it appeared inside the corresponding inline Markdown syntax. It
didn't render the Markdown, but rather approximated what the text might
look like if rendered. Because this provides little real value, and
because HLJS sometimes incorrectly parses these Markdown constructs,
markdown is dropped from the highlighting layer.

Bug: Issue 9056
Change-Id: I97865dc8b522dca5a50264456274590fac83dae9
This commit is contained in:
Wyatt Allen 2018-06-04 17:21:00 -07:00
parent eaa1783b24
commit db8691a96b
4 changed files with 48 additions and 120 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/highlightjs/building.md
View File

@ -39,7 +39,6 @@ languages included. Build it with the following:
kotlin \
lisp \
lua \
markdown \
objectivec \
ocaml \
perl \

158
lib/highlightjs/highlight.min.js vendored
View File

File diff suppressed because one or more lines are too long

3
polygerrit-ui/app/elements/diff/gr-syntax-layer/gr-syntax-layer.js
View File

@ -38,7 +38,6 @@
'text/x-java': 'java',
'text/x-kotlin': 'kotlin',
'text/x-lua': 'lua',
'text/x-markdown': 'markdown',
'text/x-objectivec': 'objectivec',
'text/x-ocaml': 'ocaml',
'text/x-perl': 'perl',
@ -62,7 +61,6 @@
'gr-diff gr-syntax gr-syntax-attribute': true,
'gr-diff gr-syntax gr-syntax-built_in': true,
'gr-diff gr-syntax gr-syntax-comment': true,
'gr-diff gr-syntax gr-syntax-emphasis': true,
'gr-diff gr-syntax gr-syntax-keyword': true,
'gr-diff gr-syntax gr-syntax-link': true,
'gr-diff gr-syntax gr-syntax-literal': true,
@ -77,7 +75,6 @@
'gr-diff gr-syntax gr-syntax-selector-pseudo': true,
'gr-diff gr-syntax gr-syntax-selector-tag': true,
'gr-diff gr-syntax gr-syntax-string': true,
'gr-diff gr-syntax gr-syntax-strong': true,
'gr-diff gr-syntax gr-syntax-tag': true,
'gr-diff gr-syntax gr-syntax-template-tag': true,
'gr-diff gr-syntax gr-syntax-template-variable': true,

6
polygerrit-ui/app/elements/diff/gr-syntax-themes/gr-syntax-theme.html
View File

@ -93,12 +93,6 @@ limitations under the License.
.gr-syntax-template-tag {
color: var(--syntax-template-tag-color);
}
.gr-syntax-emphasis {
font-style: italic;
}
.gr-syntax-strong {
font-weight: 700;
}
</style>
</template>
</dom-module>