opendev/gerrit
Code Issues Proposed changes

SuggestReviewersIT: Test for case-preserved reviewer suggestion

Browse Source 
Change-Id: I5a86603efcd31f7111c4b18304a7e6edec51ac18
This commit is contained in:
David Pursehouse
2016-02-01 19:02:41 +09:00
committed by Hugo Arès
parent 76929c4ae0
commit dbb704462b
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/SuggestReviewersIT.java
View File

@@ -55,6 +55,7 @@ public class SuggestReviewersIT extends AbstractDaemonTest {
private TestAccount user1;
private TestAccount user2;
private TestAccount user3;
private TestAccount user4;
@Before
public void setUp() throws Exception {
@@ -65,6 +66,7 @@ public class SuggestReviewersIT extends AbstractDaemonTest {
user1 = user("user1", "First1 Last1", group1);
user2 = user("user2", "First2 Last2", group2);
user3 = user("user3", "First3 Last3", group1, group2);
user4 = user("jdoe", "John Doe", "JDOE");
}
@Test
@@ -205,14 +207,18 @@ public class SuggestReviewersIT extends AbstractDaemonTest {
reviewers = suggestReviewers(changeId, user1.username, 2);
assertThat(reviewers).hasSize(1);
reviewers = suggestReviewers(changeId, "example.com", 6);
assertThat(reviewers).hasSize(5);
reviewers = suggestReviewers(changeId, "example.com", 7);
assertThat(reviewers).hasSize(6);
reviewers = suggestReviewers(changeId, user1.email, 2);
assertThat(reviewers).hasSize(1);
reviewers = suggestReviewers(changeId, user1.username + " example", 2);
assertThat(reviewers).hasSize(1);
reviewers = suggestReviewers(changeId, user4.email.toLowerCase(), 2);
assertThat(reviewers).hasSize(1);
assertThat(reviewers.get(0).account.email).isEqualTo(user4.email);
}
@Test
@@ -254,9 +260,8 @@ public class SuggestReviewersIT extends AbstractDaemonTest {
return GroupDescriptions.toAccountGroup(d);
}
private TestAccount user(String name, String fullName, AccountGroup... groups)
throws Exception {
name = name(name);
private TestAccount user(String name, String fullName, String emailName,
AccountGroup... groups) throws Exception {
String[] groupNames = FluentIterable.from(Arrays.asList(groups))
.transform(new Function<AccountGroup, String>() {
@Override
@@ -264,6 +269,12 @@ public class SuggestReviewersIT extends AbstractDaemonTest {
return in.getName();
}
}).toArray(String.class);
return accounts.create(name, name + "@example.com", fullName, groupNames);
return accounts.create(name(name), name(emailName) + "@example.com",
fullName, groupNames);
}
private TestAccount user(String name, String fullName, AccountGroup... groups)
throws Exception {
return user(name, fullName, name, groups);
}
}