ChangeNotesParser: Log only if entities were pruned
The refactoring in Ie1bb7df56a0 changed some internals in ChangeNotesParser with respect to how we account for pruned entities during parsing when the actual patch set is missing. This leads to a lot of warnings in the logs. Judging from the code it looks like we don't need to do extra book keeping anymore for pending patch sets. We keep track of pruned entities separately. This commit removes the line that adds all patch sets to the 'missing' set. 'missing' is only ever added to in the logic following this line. Instead, we populate it with patch sets that did not originate in parsing a commit (= pending). Change-Id: Ic11c4d32afe487669e85357bbed1d5d94d076a03
This commit is contained in:
@@ -999,7 +999,8 @@ class ChangeNotesParser {
|
||||
|
||||
private void updatePatchSetStates() {
|
||||
Set<PatchSet.Id> missing = new TreeSet<>(comparing(PatchSet.Id::get));
|
||||
missing.addAll(patchSets.keySet());
|
||||
patchSets.keySet().stream().filter(p -> !patchSetCommitParsed(p)).forEach(p -> missing.add(p));
|
||||
|
||||
for (Map.Entry<PatchSet.Id, PatchSetState> e : patchSetStates.entrySet()) {
|
||||
switch (e.getValue()) {
|
||||
case PUBLISHED:
|
||||
|
||||
Reference in New Issue
Block a user