opendev/gerrit
Code Issues Proposed changes

Merge "Remove unneeded submodule submit logs that spam the error log"

Browse Source
This commit is contained in:
Dave Borowitz
2018-10-02 19:15:07 +00:00
committed by Gerrit Code Review
parent aa26250a47 46986e08b8
commit dc7ec92d09
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/com/google/gerrit/server/submit/GitModules.java
View File

@@ -50,8 +50,7 @@ public class GitModules {
private static final String GIT_MODULES = ".gitmodules"; private static final String GIT_MODULES = ".gitmodules";
private final Branch.NameKey branch; private Set<SubmoduleSubscription> subscriptions;
Set<SubmoduleSubscription> subscriptions;
@Inject @Inject
GitModules( GitModules(
@@ -59,7 +58,6 @@ public class GitModules {
@Assisted Branch.NameKey branch, @Assisted Branch.NameKey branch,
@Assisted MergeOpRepoManager orm) @Assisted MergeOpRepoManager orm)
throws IOException { throws IOException {
this.branch = branch;
Project.NameKey project = branch.getParentKey(); Project.NameKey project = branch.getParentKey();
logger.atFine().log("Loading .gitmodules of %s for project %s", branch, project); logger.atFine().log("Loading .gitmodules of %s for project %s", branch, project);
try { try {
@@ -91,12 +89,10 @@ public class GitModules {
} }
} }
public Collection<SubmoduleSubscription> subscribedTo(Branch.NameKey src) { Collection<SubmoduleSubscription> subscribedTo(Branch.NameKey src) {
logger.atFine().log("Checking for a subscription of %s for %s", src, branch);
Collection<SubmoduleSubscription> ret = new ArrayList<>(); Collection<SubmoduleSubscription> ret = new ArrayList<>();
for (SubmoduleSubscription s : subscriptions) { for (SubmoduleSubscription s : subscriptions) {
if (s.getSubmodule().equals(src)) { if (s.getSubmodule().equals(src)) {
logger.atFine().log("Found %s", s);
ret.add(s); ret.add(s);
} }
} }