RefUtil#parseBaseRevision: Do not log an error if baseRevision is invalid
Callers should decide whether they want to log the InvalidRevisionException that is thrown in this case. All current callers pass in user provided input, if that is invalid it's a 400 Bad Request, but nothing that should be logged as server error. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ifdbac1bccea17f1e45a2c84b8869f9abafbd6518
This commit is contained in:
committed by
David Pursehouse
parent
822e544ac4
commit
dd07f8bcd1
@@ -55,7 +55,6 @@ public class RefUtil {
|
||||
"Cannot resolve \"%s\" in project \"%s\"", baseRevision, projectName.get());
|
||||
throw new InvalidRevisionException(baseRevision);
|
||||
} catch (RevisionSyntaxException err) {
|
||||
logger.atSevere().withCause(err).log("Invalid revision syntax \"%s\"", baseRevision);
|
||||
throw new InvalidRevisionException(baseRevision);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user