opendev/gerrit
Code Issues Proposed changes

RefUtil#parseBaseRevision: Do not log an error if baseRevision is invalid

Browse Source 
Callers should decide whether they want to log the
InvalidRevisionException that is thrown in this case. All current
callers pass in user provided input, if that is invalid it's a 400 Bad
Request, but nothing that should be logged as server error.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ifdbac1bccea17f1e45a2c84b8869f9abafbd6518
This commit is contained in:
Edwin Kempin
2019-12-05 10:28:38 +01:00
committed by David Pursehouse
parent 822e544ac4
commit dd07f8bcd1
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/server/project/RefUtil.java
View File

@@ -55,7 +55,6 @@ public class RefUtil {
"Cannot resolve \"%s\" in project \"%s\"", baseRevision, projectName.get());
throw new InvalidRevisionException(baseRevision);
} catch (RevisionSyntaxException err) {
logger.atSevere().withCause(err).log("Invalid revision syntax \"%s\"", baseRevision);
throw new InvalidRevisionException(baseRevision);
}
}