From dd1a0f8b18855e90f6da567e05ca6c9bfa57c8dd Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Wed, 3 Feb 2010 07:17:11 -0800 Subject: [PATCH] Allow refs/* pattern on new reference rights The reference name "refs/*" was being rejected because JGit's Repository.isValidRefName() method was passed "refs" and it requires there be at least one "/" in the name given. Use a special case for "refs/*" since we permit this to match any reference in the repository. Change-Id: I5e77819e8414ff7681928dcd53c2fdbbe2e0be0f Signed-off-by: Shawn O. Pearce Reviewed-by: Nico Sallembien --- .../java/com/google/gerrit/httpd/rpc/project/AddRefRight.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/AddRefRight.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/AddRefRight.java index ccaeef14a2..f72e0a8150 100644 --- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/AddRefRight.java +++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/AddRefRight.java @@ -143,7 +143,7 @@ class AddRefRight extends Handler { } if (refPattern.endsWith("/*")) { final String prefix = refPattern.substring(0, refPattern.length() - 2); - if (!Repository.isValidRefName(prefix)) { + if (!"refs".equals(prefix) && !Repository.isValidRefName(prefix)) { throw new InvalidNameException(); } } else {