opendev/gerrit
Code Issues Proposed changes

ChangeIT: remove unnecessary reviewer addition in mute test

Browse Source 
The point of the test is to confirm that the reviewer (in this case
"user") still receives email notifications when the change is muted.

It is unnecessary to also add the change owner as reviewer. This was
a copy and paste mistake when adding the test based on the test of
the ignore method.

Change-Id: I2992400cb5da1b1aed98486bdd79774fd886457e
This commit is contained in:
David Pursehouse
2017-09-19 16:13:16 +09:00
parent 978f16b72f
commit dda0082f35
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/change/ChangeIT.java
View File

@@ -3516,10 +3516,6 @@ public class ChangeIT extends AbstractDaemonTest {
in.reviewer = user.email;
gApi.changes().id(r.getChangeId()).addReviewer(in);
in = new AddReviewerInput();
in.reviewer = user2.email;
gApi.changes().id(r.getChangeId()).addReviewer(in);
setApiUser(user);
assertThat(gApi.changes().id(r.getChangeId()).muted()).isFalse();
gApi.changes().id(r.getChangeId()).mute(true);
@@ -3534,7 +3530,7 @@ public class ChangeIT extends AbstractDaemonTest {
List<Message> messages = sender.getMessages();
assertThat(messages).hasSize(1);
assertThat(messages.get(0).rcpt()).containsExactly(user.emailAddress, user2.emailAddress);
assertThat(messages.get(0).rcpt()).containsExactly(user.emailAddress);
}
@Test