opendev/gerrit
Code Issues Proposed changes

Don't bind Lucene Module in test unconditionally

Browse Source 
I805222 changed the binding to default back to Lucene for custom index
types. This breaks Google's internal test setup. If that change is
desired, we can adjust our internal setup, but that will take O(days).

This commit reverts only this chunk back to the prior state.

Change-Id: I119f073595597d467e418329d81e972bd9ebe3ab
This commit is contained in:
Patrick Hiesel
2019-10-14 11:19:47 +02:00
parent 67496e92f0
commit dde66565f6
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/testing/InMemoryModule.java
View File

@@ -227,11 +227,10 @@ public class InMemoryModule extends FactoryModule {
IndexType indexType = new IndexType(cfg.getString("index", null, "type"));
// For custom index types, callers must provide their own module.
if (indexType.isElasticsearch()) {
install(elasticIndexModule());
} else {
// Also the default "custom" module for testing.
if (indexType.isLucene()) {
install(luceneIndexModule());
} else if (indexType.isElasticsearch()) {
install(elasticIndexModule());
}
bind(ServerInformationImpl.class);
bind(ServerInformation.class).to(ServerInformationImpl.class);