diff --git a/java/com/google/gerrit/server/restapi/change/CreateChange.java b/java/com/google/gerrit/server/restapi/change/CreateChange.java index 13187b7a1e..4115bafd7c 100644 --- a/java/com/google/gerrit/server/restapi/change/CreateChange.java +++ b/java/com/google/gerrit/server/restapi/change/CreateChange.java @@ -250,10 +250,6 @@ public class CreateChange RevCommit c; if (input.merge != null) { // create a merge commit - if (!(submitType.equals(SubmitType.MERGE_ALWAYS) - || submitType.equals(SubmitType.MERGE_IF_NECESSARY))) { - throw new BadRequestException("Submit type: " + submitType + " is not supported"); - } c = newMergeCommit(git, oi, rw, projectState, mergeTip, input.merge, author, commitMessage); } else { // create an empty commit @@ -342,6 +338,13 @@ public class CreateChange me.state().getGeneralPreferences().workInProgressByDefault, false); } } + + if (input.merge != null) { + if (!(submitType.equals(SubmitType.MERGE_ALWAYS) + || submitType.equals(SubmitType.MERGE_IF_NECESSARY))) { + throw new BadRequestException("Submit type: " + submitType + " is not supported"); + } + } } private void checkRequiredPermissions(Project.NameKey project, String refName)