opendev/gerrit
Code Issues Proposed changes

Merge "Close the "Keyboard Shortcuts" popup on press"

Browse Source
This commit is contained in:
Shawn Pearce
2013-07-11 00:39:25 +00:00
committed by Gerrit Code Review
parent 53710bc051 74447c0995
commit dea55de409
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java
View File

@@ -19,8 +19,8 @@ import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.KeyCodes; import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.dom.client.KeyPressEvent; import com.google.gwt.event.dom.client.KeyPressEvent;
import com.google.gwt.event.dom.client.KeyPressHandler; import com.google.gwt.event.dom.client.KeyPressHandler;
import com.google.gwt.event.dom.client.KeyUpEvent; import com.google.gwt.event.dom.client.KeyDownEvent;
import com.google.gwt.event.dom.client.KeyUpHandler; import com.google.gwt.event.dom.client.KeyDownHandler;
import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Anchor;
import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.FlowPanel;
@@ -41,7 +41,7 @@ import java.util.List;
public class KeyHelpPopup extends PluginSafePopupPanel implements public class KeyHelpPopup extends PluginSafePopupPanel implements
KeyPressHandler, KeyUpHandler { KeyPressHandler, KeyDownHandler {
private final FocusPanel focus; private final FocusPanel focus;
public KeyHelpPopup() { public KeyHelpPopup() {
@@ -80,7 +80,7 @@ public class KeyHelpPopup extends PluginSafePopupPanel implements
DOM.setStyleAttribute(focus.getElement(), "outline", "0px"); DOM.setStyleAttribute(focus.getElement(), "outline", "0px");
DOM.setElementAttribute(focus.getElement(), "hideFocus", "true"); DOM.setElementAttribute(focus.getElement(), "hideFocus", "true");
focus.addKeyPressHandler(this); focus.addKeyPressHandler(this);
focus.addKeyUpHandler(this); focus.addKeyDownHandler(this);
add(focus); add(focus);
} }
@@ -105,7 +105,7 @@ public class KeyHelpPopup extends PluginSafePopupPanel implements
} }
@Override @Override
public void onKeyUp(final KeyUpEvent event) { public void onKeyDown(final KeyDownEvent event) {
if (event.getNativeKeyCode() == KeyCodes.KEY_ESCAPE) { if (event.getNativeKeyCode() == KeyCodes.KEY_ESCAPE) {
hide(); hide();
} }