opendev/gerrit
Code Issues Proposed changes

EditTransformer: Switch from logger.at(WARNING) to logger.atWarning()

Browse Source 
Change-Id: I561ea64305fe8dd3875d52d1a0fdffb4e4e0e948
This commit is contained in:
Alice Kober-Sotzek
2020-09-03 12:00:34 +02:00
parent bd30f710ac
commit df51c8978f
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/com/google/gerrit/server/patch/EditTransformer.java
View File

@@ -35,7 +35,6 @@ import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.function.Function;
import java.util.logging.Level;
import java.util.stream.Stream;
import org.eclipse.jgit.diff.Edit;
@@ -214,7 +213,7 @@ class EditTransformer {
// in the future.
Range updatedRange = newPosition.lineRange().orElseGet(() -> Range.create(-1, -1));
if (!newPosition.lineRange().isPresent()) {
logger.at(Level.WARNING).log(
logger.atWarning().log(
"Position %s has an empty range which is unexpected for the edits-due-to-rebase"
+ " computation. This is likely a regression!",
newPosition);
@@ -222,7 +221,7 @@ class EditTransformer {
// Same as for the range above. PATCHSET_LEVEL is a safe fallback.
String updatedFilePath = newPosition.filePath().orElse(Patch.PATCHSET_LEVEL);
if (!newPosition.filePath().isPresent()) {
logger.at(Level.WARNING).log(
logger.atWarning().log(
"Position %s has an empty file path which is unexpected for the edits-due-to-rebase"
+ " computation. This is likely a regression!",
newPosition);