opendev/gerrit
Code Issues Proposed changes

Do not call onModuleLoad() second time

Browse Source 
onModuleLoad() method is automatically called by GWT framework. Calling
it once again in PluginGenerator cause double plugin initialization.

Change-Id: I86b179f0a2da99121c74d1c095281bdd7de30636
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
This commit is contained in:
Dariusz Luksza
2012-10-30 16:20:39 +01:00
parent 9ec549cb65
commit df52478ca9
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-plugin-gwtui/src/main/java/com/google/gerrit/rebind/PluginGenerator.java
View File

@@ -72,12 +72,6 @@ public class PluginGenerator extends Generator {
// We really use a SourceWriter since it's convenient // We really use a SourceWriter since it's convenient
SourceWriter sw = f.createSourceWriter(context, out); SourceWriter sw = f.createSourceWriter(context, out);
sw.println("public " + generatedSimpleSourceName + "() {");
sw.indent();
sw.println("onModuleLoad();");
sw.outdent();
sw.println("}");
sw.commit(logger); sw.commit(logger);
} }