diff --git a/gerrit-gwtexpui/BUCK b/gerrit-gwtexpui/BUCK index e06bf17068..b266e12625 100644 --- a/gerrit-gwtexpui/BUCK +++ b/gerrit-gwtexpui/BUCK @@ -8,10 +8,10 @@ gwt_module( SRC + 'clippy/client/clippy.css', SRC + 'clippy/client/clippy.swf', ], + provided_deps = ['//lib/gwt:user'], deps = [ ':SafeHtml', ':UserAgent', - '//lib/gwt:user', '//lib:LICENSE-clippy', ], visibility = ['PUBLIC'], @@ -21,7 +21,7 @@ java_library( name = 'CSS', srcs = glob([SRC + 'css/rebind/*.java']), resources = [SRC + 'css/CSS.gwt.xml'], - deps = ['//lib/gwt:dev'], + provided_deps = ['//lib/gwt:dev'], visibility = ['PUBLIC'], ) @@ -33,10 +33,10 @@ gwt_module( SRC + 'globalkey/client/KeyConstants.properties', SRC + 'globalkey/client/key.css', ], + provided_deps = ['//lib/gwt:user'], deps = [ ':SafeHtml', ':UserAgent', - '//lib/gwt:user', ], visibility = ['PUBLIC'], ) @@ -53,7 +53,7 @@ gwt_module( srcs = glob([SRC + 'progress/client/*.java']), gwt_xml = SRC + 'progress/Progress.gwt.xml', resources = [SRC + 'progress/client/progress.css'], - deps = ['//lib/gwt:user'], + provided_deps = ['//lib/gwt:user'], visibility = ['PUBLIC'], ) @@ -62,7 +62,7 @@ gwt_module( srcs = glob([SRC + 'safehtml/client/*.java']), gwt_xml = SRC + 'safehtml/SafeHtml.gwt.xml', resources = [SRC + 'safehtml/client/safehtml.css'], - deps = ['//lib/gwt:user'], + provided_deps = ['//lib/gwt:user'], visibility = ['PUBLIC'], ) @@ -84,7 +84,7 @@ gwt_module( name = 'UserAgent', srcs = glob([SRC + 'user/client/*.java']), gwt_xml = SRC + 'user/User.gwt.xml', - deps = ['//lib/gwt:user'], + provided_deps = ['//lib/gwt:user'], visibility = ['PUBLIC'], ) @@ -94,3 +94,17 @@ java_library( provided_deps = ['//lib:servlet-api-3_1'], visibility = ['PUBLIC'], ) + +java_library( + name = 'client-src-lib', + srcs = [], + resources = glob( + [SRC + n for n in [ + 'clippy/**/*', + 'globalkey/**/*', + 'safehtml/**/*', + 'user/**/*', + ]] + ), + visibility = ['PUBLIC'], +) diff --git a/gerrit-plugin-gwtui/BUCK b/gerrit-plugin-gwtui/BUCK index 67c04c2463..07e475b25e 100644 --- a/gerrit-plugin-gwtui/BUCK +++ b/gerrit-plugin-gwtui/BUCK @@ -1,4 +1,5 @@ COMMON = ['gerrit-gwtui-common/src/main/java/'] +GWTEXPUI = ['gerrit-gwtexpui/src/main/java/'] SRC = 'src/main/java/com/google/gerrit/' SRCS = glob([SRC + '**/*.java']) @@ -26,7 +27,13 @@ java_library( name = 'gwtui-api-lib2', srcs = SRCS, resources = glob(['src/main/**/*']), - exported_deps = ['//gerrit-gwtui-common:client-lib2'], + exported_deps = [ + '//gerrit-gwtexpui:Clippy', + '//gerrit-gwtexpui:GlobalKey', + '//gerrit-gwtexpui:SafeHtml', + '//gerrit-gwtexpui:UserAgent', + '//gerrit-gwtui-common:client-lib2', + ], provided_deps = DEPS, visibility = ['PUBLIC'], ) @@ -35,6 +42,7 @@ java_binary( name = 'gwtui-api-src', deps = [ ':gwtui-api-src-lib', + '//gerrit-gwtexpui:client-src-lib', '//gerrit-gwtui-common:client-src-lib', ], visibility = ['PUBLIC'], @@ -50,9 +58,16 @@ java_library( java_doc( name = 'gwtui-api-javadoc', title = 'Gerrit Review GWT Extension API Documentation', - pkgs = ['com.google.gerrit'], - paths = ['src/main/java'] + COMMON, + pkgs = [ + 'com.google.gerrit', + 'com.google.gwtexpui.clippy', + 'com.google.gwtexpui.globalkey', + 'com.google.gwtexpui.safehtml', + 'com.google.gwtexpui.user', + ], + paths = COMMON + GWTEXPUI, srcs = SRCS, deps = DEPS + ['//gerrit-gwtui-common:client-lib2'], visibility = ['PUBLIC'], + do_it_wrong = True, )