opendev/gerrit
Code Issues Proposed changes

Rename PatchSet methods

Browse Source 
Avoid "get" prefix on getters in an AutoValue class. Rename
"getPatchSetId" to "number", to avoid giving the impression that it
returns a PatchSet.Id.

Change-Id: I6d2ff6e9c46cf21bf98b111bfc9fb81d113640b8
This commit is contained in:
Dave Borowitz
2019-04-25 10:35:01 -07:00
parent f9aab10ccc
commit df6fb38f21
113 changed files with 433 additions and 457 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/gerrit/PRED_uploader_1.java
View File

@@ -50,7 +50,7 @@ public class PRED_uploader_1 extends Predicate.P1 {
return engine.fail();
}
Account.Id uploaderId = patchSet.getUploader();
Account.Id uploaderId = patchSet.uploader();
if (!a1.unify(new StructureTerm(user, new IntegerTerm(uploaderId.get())), engine.trail)) {
return engine.fail();