opendev/gerrit
Code Issues Proposed changes

OAuth scheme: Allow to edit user name

Browse Source 
Not all OAuth providers expose user name. Most notably Google OAuth
provider does not.

Iinitially user name field was made editable for OAuth scheme in
Idc15271b6 but was undone in I0f00599dc.

Bug: Issue 4784
Change-Id: Ia37b8849b4a2eef48bf37d8517cd2fbe14d25923
This commit is contained in:
David Ostrovsky
2016-10-19 08:20:27 +02:00
parent e38eda2fd2
commit df8d479cf1
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/auth/oauth/OAuthRealm.java
View File

@@ -14,6 +14,8 @@
package com.google.gerrit.server.auth.oauth;
import static com.google.gerrit.reviewdb.client.Account.FieldName.USER_NAME;
import com.google.common.base.Strings;
import com.google.gerrit.extensions.auth.oauth.OAuthLoginProvider;
import com.google.gerrit.extensions.auth.oauth.OAuthUserInfo;
@@ -54,7 +56,7 @@ public class OAuthRealm extends AbstractRealm {
@Override
public boolean allowsEdit(FieldName field) {
return editableAccountFields.contains(field);
return field == USER_NAME || editableAccountFields.contains(field);
}
/**