diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AccountInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AccountInfo.java index 6ac0404a39..830dcb3548 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AccountInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AccountInfo.java @@ -40,9 +40,9 @@ public class AccountInfo extends JavaScriptObject { return ts; } - private final native String registeredOnRaw() /*-{ return this.registered_on; }-*/; - private final native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/; - private final native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/; + private native String registeredOnRaw() /*-{ return this.registered_on; }-*/; + private native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/; + private native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/; /** * @return true if the server supplied avatar information about this account. @@ -64,7 +64,7 @@ public class AccountInfo extends JavaScriptObject { return null; } - private final native JsArray avatars() + private native JsArray avatars() /*-{ return this.avatars }-*/; public final native void name(String n) /*-{ this.name = n }-*/; diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java index 15d1c6cc2b..0e3c32bedb 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java @@ -90,8 +90,8 @@ public class AuthInfo extends JavaScriptObject { public final native String editFullNameUrl() /*-{ return this.edit_full_name_url; }-*/; public final native String httpPasswordUrl() /*-{ return this.http_password_url; }-*/; public final native boolean isGitBasicAuth() /*-{ return this.is_git_basic_auth || false; }-*/; - private final native String authTypeRaw() /*-{ return this.auth_type; }-*/; - private final native JsArrayString _editableAccountFields() + private native String authTypeRaw() /*-{ return this.auth_type; }-*/; + private native JsArrayString _editableAccountFields() /*-{ return this.editable_account_fields; }-*/; protected AuthInfo() { diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java index 2c8555613b..1153270711 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java @@ -71,8 +71,8 @@ public class ChangeInfo extends JavaScriptObject { return revList.get(revList.length() - 1).isEdit(); } - private final native Timestamp _getCts() /*-{ return this._cts; }-*/; - private final native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/; + private native Timestamp _getCts() /*-{ return this._cts; }-*/; + private native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/; public final Timestamp updated() { return JavaSqlTimestamp_JsonSerializer.parseTimestamp(updatedRaw()); @@ -112,12 +112,12 @@ public class ChangeInfo extends JavaScriptObject { public final native boolean mergeable() /*-{ return this.mergeable ? true : false; }-*/; public final native int insertions() /*-{ return this.insertions; }-*/; public final native int deletions() /*-{ return this.deletions; }-*/; - private final native String statusRaw() /*-{ return this.status; }-*/; + private native String statusRaw() /*-{ return this.status; }-*/; public final native String subject() /*-{ return this.subject; }-*/; public final native AccountInfo owner() /*-{ return this.owner; }-*/; - private final native String createdRaw() /*-{ return this.created; }-*/; - private final native String updatedRaw() /*-{ return this.updated; }-*/; - private final native String submittedRaw() /*-{ return this.submitted; }-*/; + private native String createdRaw() /*-{ return this.created; }-*/; + private native String updatedRaw() /*-{ return this.updated; }-*/; + private native String submittedRaw() /*-{ return this.submitted; }-*/; public final native boolean starred() /*-{ return this.starred ? true : false; }-*/; public final native boolean reviewed() /*-{ return this.reviewed ? true : false; }-*/; public final native NativeMap allLabels() /*-{ return this.labels; }-*/; @@ -142,7 +142,7 @@ public class ChangeInfo extends JavaScriptObject { public final native JsArray removableReviewers() /*-{ return this.removable_reviewers; }-*/; - private final native NativeMap> _reviewers() + private native NativeMap> _reviewers() /*-{ return this.reviewers; }-*/; public final Map> reviewers() { NativeMap> reviewers = _reviewers(); @@ -173,14 +173,14 @@ public class ChangeInfo extends JavaScriptObject { } return SubmitType.valueOf(submitType); } - private final native String _submitType() /*-{ return this.submit_type; }-*/; + private native String _submitType() /*-{ return this.submit_type; }-*/; public final boolean submittable() { init(); return _submittable(); } - private final native boolean _submittable() + private native boolean _submittable() /*-{ return this.submittable ? true : false; }-*/; /** @@ -259,7 +259,7 @@ public class ChangeInfo extends JavaScriptObject { return null; } - private final native NativeMap _values() /*-{ return this.values; }-*/; + private native NativeMap _values() /*-{ return this.values; }-*/; public final Set values() { return Natives.keys(_values()); } @@ -334,7 +334,7 @@ public class ChangeInfo extends JavaScriptObject { revisionInfo.takeFromEdit(edit); return revisionInfo; } - private final native void takeFromEdit(EditInfo edit) /*-{ + private native void takeFromEdit(EditInfo edit) /*-{ this._number = 0; this.name = edit.name; this.commit = edit.commit; @@ -435,7 +435,7 @@ public class ChangeInfo extends JavaScriptObject { public static class GitPerson extends JavaScriptObject { public final native String name() /*-{ return this.name; }-*/; public final native String email() /*-{ return this.email; }-*/; - private final native String dateRaw() /*-{ return this.date; }-*/; + private native String dateRaw() /*-{ return this.date; }-*/; public final Timestamp date() { return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw()); @@ -449,7 +449,7 @@ public class ChangeInfo extends JavaScriptObject { public final native AccountInfo author() /*-{ return this.author; }-*/; public final native String message() /*-{ return this.message; }-*/; public final native int _revisionNumber() /*-{ return this._revision_number || 0; }-*/; - private final native String dateRaw() /*-{ return this.date; }-*/; + private native String dateRaw() /*-{ return this.date; }-*/; public final Timestamp date() { return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw()); @@ -475,7 +475,7 @@ public class ChangeInfo extends JavaScriptObject { public final native JsArrayString branches() /*-{ return this.branches; }-*/; public final native JsArrayString tags() /*-{ return this.tags; }-*/; public final native JsArrayString external(String n) /*-{ return this.external[n]; }-*/; - private final native NativeMap external() /*-{ return this.external; }-*/; + private native NativeMap external() /*-{ return this.external; }-*/; protected IncludedInInfo() { } diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/DownloadInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/DownloadInfo.java index eee2847722..183e6af6ff 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/DownloadInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/DownloadInfo.java @@ -39,8 +39,8 @@ public class DownloadInfo extends JavaScriptObject { } public final native DownloadSchemeInfo scheme(String n) /*-{ return this.schemes[n]; }-*/; - private final native NativeMap _schemes() /*-{ return this.schemes; }-*/; - private final native JsArrayString _archives() /*-{ return this.archives; }-*/; + private native NativeMap _schemes() /*-{ return this.schemes; }-*/; + private native JsArrayString _archives() /*-{ return this.archives; }-*/; protected DownloadInfo() { } @@ -96,8 +96,8 @@ public class DownloadInfo extends JavaScriptObject { public final native boolean isAuthSupported() /*-{ return this.is_auth_supported || false; }-*/; public final native String command(String n) /*-{ return this.commands[n]; }-*/; public final native String cloneCommand(String n) /*-{ return this.clone_commands[n]; }-*/; - private final native NativeMap _commands() /*-{ return this.commands; }-*/; - private final native NativeMap _cloneCommands() /*-{ return this.clone_commands; }-*/; + private native NativeMap _commands() /*-{ return this.commands; }-*/; + private native NativeMap _cloneCommands() /*-{ return this.clone_commands; }-*/; protected DownloadSchemeInfo() { } diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java index 555e06eff0..9b290a5d21 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java @@ -37,12 +37,12 @@ public class FileInfo extends JavaScriptObject { public final long size() { return (long)_size(); } - private final native double _size() /*-{ return this.size || 0; }-*/; + private native double _size() /*-{ return this.size || 0; }-*/; public final long sizeDelta() { return (long)_sizeDelta(); } - private final native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/; + private native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/; public final native int _row() /*-{ return this._row }-*/; public final native void _row(int r) /*-{ this._row = r }-*/; diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GeneralPreferences.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GeneralPreferences.java index 40e6278eb8..45953cb763 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GeneralPreferences.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GeneralPreferences.java @@ -65,7 +65,7 @@ public class GeneralPreferences extends JavaScriptObject { ? changesPerPage : GeneralPreferencesInfo.DEFAULT_PAGESIZE; } - private final native short get(String n, int d) + private native short get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; public final native boolean showSiteHeader() @@ -81,21 +81,21 @@ public class GeneralPreferences extends JavaScriptObject { String s = downloadCommandRaw(); return s != null ? DownloadCommand.valueOf(s) : null; } - private final native String downloadCommandRaw() + private native String downloadCommandRaw() /*-{ return this.download_command }-*/; public final DateFormat dateFormat() { String s = dateFormatRaw(); return s != null ? DateFormat.valueOf(s) : null; } - private final native String dateFormatRaw() + private native String dateFormatRaw() /*-{ return this.date_format }-*/; public final TimeFormat timeFormat() { String s = timeFormatRaw(); return s != null ? TimeFormat.valueOf(s) : null; } - private final native String timeFormatRaw() + private native String timeFormatRaw() /*-{ return this.time_format }-*/; public final native boolean relativeDateInChangeTable() @@ -117,14 +117,14 @@ public class GeneralPreferences extends JavaScriptObject { String s = reviewCategeoryStrategyRaw(); return s != null ? ReviewCategoryStrategy.valueOf(s) : ReviewCategoryStrategy.NONE; } - private final native String reviewCategeoryStrategyRaw() + private native String reviewCategeoryStrategyRaw() /*-{ return this.review_category_strategy }-*/; public final DiffView diffView() { String s = diffViewRaw(); return s != null ? DiffView.valueOf(s) : null; } - private final native String diffViewRaw() + private native String diffViewRaw() /*-{ return this.diff_view }-*/; public final EmailStrategy emailStrategy() { @@ -132,7 +132,7 @@ public class GeneralPreferences extends JavaScriptObject { return s != null ? EmailStrategy.valueOf(s) : null; } - private final native String emailStrategyRaw() + private native String emailStrategyRaw() /*-{ return this.email_strategy }-*/; public final native JsArray my() @@ -159,13 +159,13 @@ public class GeneralPreferences extends JavaScriptObject { public final void dateFormat(DateFormat f) { dateFormatRaw(f != null ? f.toString() : null); } - private final native void dateFormatRaw(String f) + private native void dateFormatRaw(String f) /*-{ this.date_format = f }-*/; public final void timeFormat(TimeFormat f) { timeFormatRaw(f != null ? f.toString() : null); } - private final native void timeFormatRaw(String f) + private native void timeFormatRaw(String f) /*-{ this.time_format = f }-*/; public final native void relativeDateInChangeTable(boolean d) @@ -186,19 +186,19 @@ public class GeneralPreferences extends JavaScriptObject { public final void reviewCategoryStrategy(ReviewCategoryStrategy s) { reviewCategoryStrategyRaw(s != null ? s.toString() : null); } - private final native void reviewCategoryStrategyRaw(String s) + private native void reviewCategoryStrategyRaw(String s) /*-{ this.review_category_strategy = s }-*/; public final void diffView(DiffView d) { diffViewRaw(d != null ? d.toString() : null); } - private final native void diffViewRaw(String d) + private native void diffViewRaw(String d) /*-{ this.diff_view = d }-*/; public final void emailStrategy(EmailStrategy s) { emailStrategyRaw(s != null ? s.toString() : null); } - private final native void emailStrategyRaw(String s) + private native void emailStrategyRaw(String s) /*-{ this.email_strategy = s }-*/; public final void setMyMenus(List myMenus) { @@ -218,8 +218,8 @@ public class GeneralPreferences extends JavaScriptObject { return urlAliases; } - private final native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/; - private final native NativeMap _urlAliases() /*-{ return this.url_aliases; }-*/; + private native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/; + private native NativeMap _urlAliases() /*-{ return this.url_aliases; }-*/; public final void setUrlAliases(Map urlAliases) { initUrlAliases(); @@ -227,8 +227,8 @@ public class GeneralPreferences extends JavaScriptObject { putUrlAlias(e.getKey(), e.getValue()); } } - private final native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/; - private final native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/; + private native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/; + private native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/; protected GeneralPreferences() { } diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GpgKeyInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GpgKeyInfo.java index f7477a1d73..7955347871 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GpgKeyInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GpgKeyInfo.java @@ -27,7 +27,7 @@ public class GpgKeyInfo extends JavaScriptObject { public final native JsArrayString userIds() /*-{ return this.user_ids; }-*/; public final native String key() /*-{ return this.key; }-*/; - private final native String statusRaw() /*-{ return this.status; }-*/; + private native String statusRaw() /*-{ return this.status; }-*/; public final Status status() { String s = statusRaw(); if (s == null) { diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ServerInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ServerInfo.java index b0e52fa9c2..b0af73dcf6 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ServerInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ServerInfo.java @@ -43,7 +43,7 @@ public class ServerInfo extends JavaScriptObject { } public final native String urlAliasToken(String n) /*-{ return this.url_aliases[n]; }-*/; - private final native NativeMap _urlAliases() /*-{ return this.url_aliases; }-*/; + private native NativeMap _urlAliases() /*-{ return this.url_aliases; }-*/; public final boolean hasSshd() { diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/rpc/NativeString.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/rpc/NativeString.java index 0e16dc038c..c5884e6374 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/rpc/NativeString.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/rpc/NativeString.java @@ -22,7 +22,7 @@ public final class NativeString extends JavaScriptObject { public static final JavaScriptObject TYPE = init(); // Used from core and plugins - private static final native JavaScriptObject init() /*-{ + private static native JavaScriptObject init() /*-{ if ($wnd.Gerrit === undefined || $wnd.Gerrit.JsonString === undefined) { return function(s){this.s=s}; } else { @@ -34,7 +34,7 @@ public final class NativeString extends JavaScriptObject { return wrap0(TYPE, s); } - private static final native NativeString wrap0(JavaScriptObject T, String s) + private static native NativeString wrap0(JavaScriptObject T, String s) /*-{ return new T(s) }-*/; public final native String asString() /*-{ return this.s; }-*/; @@ -58,7 +58,7 @@ public final class NativeString extends JavaScriptObject { return is(TYPE, o); } - private static final native boolean is(JavaScriptObject T, JavaScriptObject o) + private static native boolean is(JavaScriptObject T, JavaScriptObject o) /*-{ return o instanceof T }-*/; protected NativeString() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/DiffPreferences.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/DiffPreferences.java index 7d543d86bd..e65d637c64 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/DiffPreferences.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/DiffPreferences.java @@ -158,11 +158,11 @@ public class DiffPreferences extends JavaScriptObject { public final native boolean skipDeleted() /*-{ return this.skip_deleted || false }-*/; public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/; - private final native void setThemeRaw(String i) /*-{ this.theme = i }-*/; - private final native void setIgnoreWhitespaceRaw(String i) /*-{ this.ignore_whitespace = i }-*/; - private final native String ignoreWhitespaceRaw() /*-{ return this.ignore_whitespace }-*/; - private final native String themeRaw() /*-{ return this.theme }-*/; - private final native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; + private native void setThemeRaw(String i) /*-{ this.theme = i }-*/; + private native void setIgnoreWhitespaceRaw(String i) /*-{ this.ignore_whitespace = i }-*/; + private native String ignoreWhitespaceRaw() /*-{ return this.ignore_whitespace }-*/; + private native String themeRaw() /*-{ return this.theme }-*/; + private native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; protected DiffPreferences() { } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/EditPreferences.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/EditPreferences.java index d37ddd5574..de686524ed 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/EditPreferences.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/account/EditPreferences.java @@ -56,12 +56,12 @@ public class EditPreferences extends JavaScriptObject { public final void theme(Theme i) { setThemeRaw(i != null ? i.toString() : Theme.DEFAULT.toString()); } - private final native void setThemeRaw(String i) /*-{ this.theme = i }-*/; + private native void setThemeRaw(String i) /*-{ this.theme = i }-*/; public final void keyMapType(KeyMapType i) { setkeyMapTypeRaw(i != null ? i.toString() : KeyMapType.DEFAULT.toString()); } - private final native void setkeyMapTypeRaw(String i) /*-{ this.key_map_type = i }-*/; + private native void setkeyMapTypeRaw(String i) /*-{ this.key_map_type = i }-*/; public final native void tabSize(int t) /*-{ this.tab_size = t }-*/; public final native void lineLength(int c) /*-{ this.line_length = c }-*/; @@ -78,13 +78,13 @@ public class EditPreferences extends JavaScriptObject { String s = themeRaw(); return s != null ? Theme.valueOf(s) : Theme.DEFAULT; } - private final native String themeRaw() /*-{ return this.theme }-*/; + private native String themeRaw() /*-{ return this.theme }-*/; public final KeyMapType keyMapType() { String s = keyMapTypeRaw(); return s != null ? KeyMapType.valueOf(s) : KeyMapType.DEFAULT; } - private final native String keyMapTypeRaw() /*-{ return this.key_map_type }-*/; + private native String keyMapTypeRaw() /*-{ return this.key_map_type }-*/; public final int tabSize() { return get("tab_size", 8); @@ -105,7 +105,7 @@ public class EditPreferences extends JavaScriptObject { public final native boolean hideLineNumbers() /*-{ return this.hide_line_numbers || false }-*/; public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/; public final native boolean autoCloseBrackets() /*-{ return this.auto_close_brackets || false }-*/; - private final native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; + private native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/; protected EditPreferences() { } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java index 82b6810592..1e77773063 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java @@ -55,11 +55,11 @@ public class ChangeGlue { } } - private static final native JavaScriptObject get(String id) /*-{ + private static native JavaScriptObject get(String id) /*-{ return $wnd.Gerrit.change_actions[id]; }-*/; - private static final native boolean invoke(JavaScriptObject h, + private static native boolean invoke(JavaScriptObject h, ChangeInfo a, RevisionInfo r) /*-{ return h(a,r) }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java index 49b150aa60..b7e3df33a2 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java @@ -45,7 +45,7 @@ public class EditGlue { } } - private static final native JavaScriptObject get(String id) /*-{ + private static native JavaScriptObject get(String id) /*-{ return $wnd.Gerrit.edit_actions[id]; }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionPanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionPanel.java index 0702cba7c4..e20c577c15 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionPanel.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionPanel.java @@ -130,14 +130,14 @@ public class ExtensionPanel extends FlowPanel { final native void putBoolean(String k, boolean v) /*-{ this.p[k] = v; }-*/; final native void putObject(String k, JavaScriptObject v) /*-{ this.p[k] = v; }-*/; - private static final native Context create( + private static native Context create( JavaScriptObject T, Definition d, Element e) /*-{ return new T(d,e) }-*/; private static final JavaScriptObject TYPE = init(); - private static final native JavaScriptObject init() /*-{ + private static native JavaScriptObject init() /*-{ var T = function(d,e) { this._d = d; this._u = []; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionScreen.java index 98b06bbcbc..19dbe06c48 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionScreen.java @@ -109,7 +109,7 @@ public class ExtensionScreen extends Screen { final native void onLoad() /*-{ this._d.onLoad(this) }-*/; final native JsArray unload() /*-{ return this._u }-*/; - private static final native Context create( + private static native Context create( JavaScriptObject T, Definition d, ExtensionScreen s, @@ -118,7 +118,7 @@ public class ExtensionScreen extends Screen { /*-{ return new T(d,s,e,m) }-*/; private static final JavaScriptObject TYPE = init(); - private static final native JavaScriptObject init() /*-{ + private static native JavaScriptObject init() /*-{ var T = function(d,s,e,m) { this._d = d; this._s = s; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionSettingsScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionSettingsScreen.java index c351bbfb43..1d7259b9dc 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionSettingsScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionSettingsScreen.java @@ -91,7 +91,7 @@ public class ExtensionSettingsScreen extends SettingsScreen { return Natives.keys(settingsScreens()); } - private static final native NativeMap settingsScreens() + private static native NativeMap settingsScreens() /*-{ return $wnd.Gerrit.settingsScreens; }-*/; public final native String getPath() /*-{ return this.path; }-*/; @@ -114,7 +114,7 @@ public class ExtensionSettingsScreen extends SettingsScreen { final native void onLoad() /*-{ this._d.onLoad(this) }-*/; final native JsArray unload() /*-{ return this._u }-*/; - private static final native Context create( + private static native Context create( JavaScriptObject T, Definition d, ExtensionSettingsScreen s, @@ -122,7 +122,7 @@ public class ExtensionSettingsScreen extends SettingsScreen { /*-{ return new T(d,s,e) }-*/; private static final JavaScriptObject TYPE = init(); - private static final native JavaScriptObject init() /*-{ + private static native JavaScriptObject init() /*-{ var T = function(d,s,e) { this._d = d; this._s = s; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java index a560711cdc..330ec15a65 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java @@ -76,7 +76,7 @@ class PluginName { protected static final native JavaScriptException makeException() /*-{ try { null.a() } catch (e) { return e } }-*/; - private static final native boolean hasStack(JavaScriptException e) + private static native boolean hasStack(JavaScriptException e) /*-{ return !!e.stack }-*/; /** Extracts URL from the stack frame. */ @@ -103,7 +103,7 @@ class PluginName { return UNKNOWN; } - private static final native JsArrayString getStack(JavaScriptException e) + private static native JsArrayString getStack(JavaScriptException e) /*-{ return e.stack ? e.stack.split('\n') : [] }-*/; } } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java index 69887e7363..f9084d9147 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java @@ -61,11 +61,11 @@ public class ProjectGlue { } } - private static final native JavaScriptObject projectAction(String id) /*-{ + private static native JavaScriptObject projectAction(String id) /*-{ return $wnd.Gerrit.project_actions[id]; }-*/; - private static final native JavaScriptObject branchAction(String id) /*-{ + private static native JavaScriptObject branchAction(String id) /*-{ return $wnd.Gerrit.branch_actions[id]; }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java index 914ef85917..50ebce7a03 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java @@ -46,7 +46,7 @@ public class RevisionGlue { } } - private static final native JavaScriptObject get(String id) /*-{ + private static native JavaScriptObject get(String id) /*-{ return $wnd.Gerrit.revision_actions[id]; }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java index 41f0f21303..46702ec94c 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java @@ -115,7 +115,7 @@ public class FileTable extends FlowPanel { init(DELETE, RESTORE, REVIEWED, OPEN); } - private static final native void init(String d, String t, String r, String o) /*-{ + private static native void init(String d, String t, String r, String o) /*-{ $wnd[d] = $entry(function(e,i) { @com.google.gerrit.client.change.FileTable::onDelete(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i) }); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java index 594550dd3f..1dc99b48f1 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java @@ -62,7 +62,7 @@ public class Hashtags extends Composite { init(REMOVE); } - private static final native void init(String r) /*-{ + private static native void init(String r) /*-{ $wnd[r] = $entry(function(e) { @com.google.gerrit.client.change.Hashtags::onRemove(Lcom/google/gwt/dom/client/NativeEvent;)(e) }); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java index 827362ee30..89550c6ec2 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java @@ -59,7 +59,7 @@ class Labels extends Grid { init(REMOVE_REVIEWER, REMOVE_VOTE); } - private static final native void init(String r, String v) /*-{ + private static native void init(String r, String v) /*-{ $wnd[r] = $entry(function(e) { @com.google.gerrit.client.change.Labels::onRemoveReviewer(Lcom/google/gwt/dom/client/NativeEvent;)(e) }); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java index 1d7661237e..1753c7b962 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java @@ -63,7 +63,7 @@ class PatchSetsBox extends Composite { init(OPEN); } - private static final native void init(String o) /*-{ + private static native void init(String o) /*-{ $wnd[o] = $entry(function(e,i) { return @com.google.gerrit.client.change.PatchSetsBox::onOpen(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i); }); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java index 527e5907f2..d22294212d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java @@ -385,7 +385,7 @@ public class RelatedChanges extends TabPanel { String s = statusRaw(); return s != null ? Change.Status.valueOf(s) : null; } - private final native String statusRaw() /*-{ return this.status; }-*/; + private native String statusRaw() /*-{ return this.status; }-*/; final native void setId(String i) /*-{ if(i)this.change_id=i; }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java index cc34df294f..788b4b09d1 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java @@ -67,7 +67,7 @@ class RelatedChangesTab implements IsWidget { private static final SafeHtml POINTER_HTML = AbstractImagePrototype.create(Gerrit.RESOURCES.arrowRight()).getSafeHtml(); - private static final native String init(String o) /*-{ + private static native String init(String o) /*-{ $wnd[o] = $entry(@com.google.gerrit.client.change.RelatedChangesTab::onOpen( Lcom/google/gwt/dom/client/NativeEvent;Lcom/google/gwt/dom/client/Element;)); return o + '(event,this)'; @@ -599,7 +599,7 @@ class RelatedChangesTab implements IsWidget { } } - private static final native Node createDocumentFragment() /*-{ + private static native Node createDocumentFragment() /*-{ return $doc.createDocumentFragment(); }-*/; } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java index 71942cedf0..b69d1c0384 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java @@ -293,7 +293,7 @@ public class Reviewers extends Composite { return Natives.keys(_approvals()); } final native String approval(String l) /*-{ return this.approvals[l]; }-*/; - private final native NativeMap _approvals() /*-{ return this.approvals; }-*/; + private native NativeMap _approvals() /*-{ return this.approvals; }-*/; protected ReviewerInfo() { } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommentInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommentInfo.java index 9088c1c5ce..8e73f733d1 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommentInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommentInfo.java @@ -77,7 +77,7 @@ public class CommentInfo extends JavaScriptObject { public final void side(Side side) { sideRaw(side.toString()); } - private final native void sideRaw(String s) /*-{ this.side = s }-*/; + private native void sideRaw(String s) /*-{ this.side = s }-*/; public final native String path() /*-{ return this.path }-*/; public final native String id() /*-{ return this.id }-*/; @@ -90,7 +90,7 @@ public class CommentInfo extends JavaScriptObject { ? Side.valueOf(s) : Side.REVISION; } - private final native String sideRaw() /*-{ return this.side }-*/; + private native String sideRaw() /*-{ return this.side }-*/; public final Timestamp updated() { Timestamp r = updatedTimestamp(); @@ -103,9 +103,9 @@ public class CommentInfo extends JavaScriptObject { } return r; } - private final native String updatedRaw() /*-{ return this.updated }-*/; - private final native Timestamp updatedTimestamp() /*-{ return this._ts }-*/; - private final native void updatedTimestamp(Timestamp t) /*-{ this._ts = t }-*/; + private native String updatedRaw() /*-{ return this.updated }-*/; + private native Timestamp updatedTimestamp() /*-{ return this._ts }-*/; + private native void updatedTimestamp(Timestamp t) /*-{ this._ts = t }-*/; public final native AccountInfo author() /*-{ return this.author }-*/; public final native int line() /*-{ return this.line || 0 }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java index 0f22a237d7..a127e7f389 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java @@ -42,14 +42,14 @@ public class ReviewInput extends JavaScriptObject { public final void notify(NotifyHandling e) { _notify(e.name()); } - private final native void _notify(String n) /*-{ this.notify=n; }-*/; + private native void _notify(String n) /*-{ this.notify=n; }-*/; public final void drafts(DraftHandling e) { _drafts(e.name()); } - private final native void _drafts(String n) /*-{ this.drafts=n; }-*/; + private native void _drafts(String n) /*-{ this.drafts=n; }-*/; - private final native void init() /*-{ + private native void init() /*-{ this.labels = {}; this.strict_labels = true; }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/SubmitInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/SubmitInfo.java index 6d8bc308db..7a24774263 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/SubmitInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/SubmitInfo.java @@ -22,7 +22,7 @@ public class SubmitInfo extends JavaScriptObject { return Change.Status.valueOf(statusRaw()); } - private final native String statusRaw() /*-{ return this.status; }-*/; + private native String statusRaw() /*-{ return this.status; }-*/; protected SubmitInfo() { } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentRange.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentRange.java index 9f46e9b6fb..cd791aebd2 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentRange.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentRange.java @@ -43,7 +43,7 @@ public class CommentRange extends JavaScriptObject { public final native int endLine() /*-{ return this.end_line; }-*/; public final native int endCharacter() /*-{ return this.end_character; }-*/; - private final native void set(int sl, int sc, int el, int ec) /*-{ + private native void set(int sl, int sc, int el, int ec) /*-{ this.start_line = sl; this.start_character = sc; this.end_line = el; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java index 82dad3f908..6812418a4b 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java @@ -66,7 +66,7 @@ public class DiffInfo extends JavaScriptObject { public final ChangeType changeType() { return ChangeType.valueOf(changeTypeRaw()); } - private final native String changeTypeRaw() + private native String changeTypeRaw() /*-{ return this.change_type }-*/; public final IntraLineStatus intralineStatus() { @@ -75,7 +75,7 @@ public class DiffInfo extends JavaScriptObject { ? IntraLineStatus.valueOf(s) : IntraLineStatus.OFF; } - private final native String intralineStatusRaw() + private native String intralineStatusRaw() /*-{ return this.intraline_status }-*/; public final boolean hasSkip() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySideChunkManager.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySideChunkManager.java index dcbcb6737a..cbbafada24 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySideChunkManager.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySideChunkManager.java @@ -45,7 +45,7 @@ class SideBySideChunkManager extends ChunkManager { private static double guessedLineHeightPx = 15; private static final JavaScriptObject focusA = initOnClick(A); private static final JavaScriptObject focusB = initOnClick(B); - private static final native JavaScriptObject initOnClick(DisplaySide s) /*-{ + private static native JavaScriptObject initOnClick(DisplaySide s) /*-{ return $entry(function(e){ @com.google.gerrit.client.diff.SideBySideChunkManager::focus( Lcom/google/gwt/dom/client/NativeEvent; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/UnifiedChunkManager.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/UnifiedChunkManager.java index 866f0f7af6..c7eca0b232 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/UnifiedChunkManager.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/UnifiedChunkManager.java @@ -38,7 +38,7 @@ import java.util.List; /** Colors modified regions for {@link Unified}. */ class UnifiedChunkManager extends ChunkManager { private static final JavaScriptObject focus = initOnClick(); - private static final native JavaScriptObject initOnClick() /*-{ + private static native JavaScriptObject initOnClick() /*-{ return $entry(function(e){ @com.google.gerrit.client.diff.UnifiedChunkManager::focus( Lcom/google/gwt/dom/client/NativeEvent;)(e) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupAuditEventInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupAuditEventInfo.java index f62ae229a0..ed41b650f7 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupAuditEventInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupAuditEventInfo.java @@ -37,8 +37,8 @@ public class GroupAuditEventInfo extends JavaScriptObject { public final native AccountInfo memberAsUser() /*-{ return this.member; }-*/; public final native GroupInfo memberAsGroup() /*-{ return this.member; }-*/; - private final native String dateRaw() /*-{ return this.date; }-*/; - private final native String typeRaw() /*-{ return this.type; }-*/; + private native String dateRaw() /*-{ return this.date; }-*/; + private native String typeRaw() /*-{ return this.type; }-*/; protected GroupAuditEventInfo() { } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupInfo.java index 6142e5b701..c3fd4ed7de 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupInfo.java @@ -33,9 +33,9 @@ public class GroupInfo extends GroupBaseInfo { public final native JsArray members() /*-{ return this.members; }-*/; public final native JsArray includes() /*-{ return this.includes; }-*/; - private final native int group_id() /*-{ return this.group_id; }-*/; - private final native String owner_id() /*-{ return this.owner_id; }-*/; - private final native void owner_id(String o) /*-{ if(o)this.owner_id=o; }-*/; + private native int group_id() /*-{ return this.group_id; }-*/; + private native String owner_id() /*-{ return this.owner_id; }-*/; + private native void owner_id(String o) /*-{ if(o)this.owner_id=o; }-*/; public final AccountGroup.UUID getOwnerUUID() { String owner = owner_id(); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java index 322a354553..96b25c5ce3 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java @@ -69,7 +69,7 @@ public class ConfigInfo extends JavaScriptObject { public final native NativeMap actions() /*-{ return this.actions; }-*/; - private final native String submitTypeRaw() + private native String submitTypeRaw() /*-{ return this.submit_type }-*/; public final ProjectState state() { @@ -78,13 +78,13 @@ public class ConfigInfo extends JavaScriptObject { } return ProjectState.valueOf(stateRaw()); } - private final native String stateRaw() + private native String stateRaw() /*-{ return this.state }-*/; public final native MaxObjectSizeLimitInfo maxObjectSizeLimit() /*-{ return this.max_object_size_limit; }-*/; - private final native NativeMap commentlinks0() + private native NativeMap commentlinks0() /*-{ return this.commentlinks; }-*/; final List commentlinks() { JsArray cls = commentlinks0().values(); @@ -143,7 +143,7 @@ public class ConfigInfo extends JavaScriptObject { public final InheritableBoolean configuredValue() { return InheritableBoolean.valueOf(configuredValueRaw()); } - private final native String configuredValueRaw() + private native String configuredValueRaw() /*-{ return this.configured_value }-*/; public final void setConfiguredValue(InheritableBoolean v) { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectApi.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectApi.java index fffdd3f208..8e29e4cefa 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectApi.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectApi.java @@ -228,43 +228,43 @@ public class ProjectApi { final void setUseContributorAgreements(InheritableBoolean v) { setUseContributorAgreementsRaw(v.name()); } - private final native void setUseContributorAgreementsRaw(String v) + private native void setUseContributorAgreementsRaw(String v) /*-{ if(v)this.use_contributor_agreements=v; }-*/; final void setUseContentMerge(InheritableBoolean v) { setUseContentMergeRaw(v.name()); } - private final native void setUseContentMergeRaw(String v) + private native void setUseContentMergeRaw(String v) /*-{ if(v)this.use_content_merge=v; }-*/; final void setUseSignedOffBy(InheritableBoolean v) { setUseSignedOffByRaw(v.name()); } - private final native void setUseSignedOffByRaw(String v) + private native void setUseSignedOffByRaw(String v) /*-{ if(v)this.use_signed_off_by=v; }-*/; final void setRequireChangeId(InheritableBoolean v) { setRequireChangeIdRaw(v.name()); } - private final native void setRequireChangeIdRaw(String v) + private native void setRequireChangeIdRaw(String v) /*-{ if(v)this.require_change_id=v; }-*/; final void setCreateNewChangeForAllNotInTarget(InheritableBoolean v) { setCreateNewChangeForAllNotInTargetRaw(v.name()); } - private final native void setCreateNewChangeForAllNotInTargetRaw(String v) + private native void setCreateNewChangeForAllNotInTargetRaw(String v) /*-{ if(v)this.create_new_change_for_all_not_in_target=v; }-*/; final void setEnableSignedPush(InheritableBoolean v) { setEnableSignedPushRaw(v.name()); } - private final native void setEnableSignedPushRaw(String v) + private native void setEnableSignedPushRaw(String v) /*-{ if(v)this.enable_signed_push=v; }-*/; final void setRequireSignedPush(InheritableBoolean v) { setRequireSignedPushRaw(v.name()); } - private final native void setRequireSignedPushRaw(String v) + private native void setRequireSignedPushRaw(String v) /*-{ if(v)this.require_signed_push=v; }-*/; final native void setMaxObjectSizeLimit(String l) @@ -273,13 +273,13 @@ public class ProjectApi { final void setSubmitType(SubmitType t) { setSubmitTypeRaw(t.name()); } - private final native void setSubmitTypeRaw(String t) + private native void setSubmitTypeRaw(String t) /*-{ if(t)this.submit_type=t; }-*/; final void setState(ProjectState s) { setStateRaw(s.name()); } - private final native void setStateRaw(String s) + private native void setStateRaw(String s) /*-{ if(s)this.state=s; }-*/; final void setPluginConfigValues(Map> pluginConfigValues) { @@ -295,7 +295,7 @@ public class ProjectApi { setPluginConfigValuesRaw(configValues); } } - private final native void setPluginConfigValuesRaw(NativeMap v) + private native void setPluginConfigValuesRaw(NativeMap v) /*-{ this.plugin_config_values=v; }-*/; } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java index 00a403484a..eed9d1dc29 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java @@ -36,7 +36,7 @@ public class ProjectInfo return ProjectState.valueOf(getStringState()); } - private final native String getStringState() /*-{ return this.state; }-*/; + private native String getStringState() /*-{ return this.state; }-*/; @Override public final String getDisplayString() { diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java index 88ee29306a..e77bc10456 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java @@ -222,9 +222,9 @@ public abstract class FancyFlexTable extends Composite { protected static class MyFlexTable extends FlexTable { } - private static final native void setRowItem(Element td, ItemType c) + private static native void setRowItem(Element td, ItemType c) /*-{ td['__gerritRowItem'] = c; }-*/; - private static final native ItemType getRowItem(Element td) + private static native ItemType getRowItem(Element td) /*-{ return td['__gerritRowItem']; }-*/; } diff --git a/gerrit-gwtui/src/main/java/net/codemirror/lib/CodeMirror.java b/gerrit-gwtui/src/main/java/net/codemirror/lib/CodeMirror.java index ee4c05031e..eccde6f442 100644 --- a/gerrit-gwtui/src/main/java/net/codemirror/lib/CodeMirror.java +++ b/gerrit-gwtui/src/main/java/net/codemirror/lib/CodeMirror.java @@ -138,7 +138,7 @@ public class CodeMirror extends JavaScriptObject { addLineClassNative(line, where.value(), className); } - private final native void addLineClassNative(int line, String where, + private native void addLineClassNative(int line, String where, String lineClass) /*-{ this.addLineClass(line, where, lineClass) }-*/; @@ -148,7 +148,7 @@ public class CodeMirror extends JavaScriptObject { addLineClassNative(line, where.value(), className); } - private final native void addLineClassNative(LineHandle line, String where, + private native void addLineClassNative(LineHandle line, String where, String lineClass) /*-{ this.addLineClass(line, where, lineClass) }-*/; @@ -158,7 +158,7 @@ public class CodeMirror extends JavaScriptObject { removeLineClassNative(line, where.value(), className); } - private final native void removeLineClassNative(int line, String where, + private native void removeLineClassNative(int line, String where, String lineClass) /*-{ this.removeLineClass(line, where, lineClass) }-*/; @@ -168,7 +168,7 @@ public class CodeMirror extends JavaScriptObject { removeLineClassNative(line, where.value(), className); } - private final native void removeLineClassNative(LineHandle line, String where, + private native void removeLineClassNative(LineHandle line, String where, String lineClass) /*-{ this.removeLineClass(line, where, lineClass) }-*/; diff --git a/gerrit-gwtui/src/main/java/net/codemirror/lib/Extras.java b/gerrit-gwtui/src/main/java/net/codemirror/lib/Extras.java index 13186d19a2..f2fc074198 100644 --- a/gerrit-gwtui/src/main/java/net/codemirror/lib/Extras.java +++ b/gerrit-gwtui/src/main/java/net/codemirror/lib/Extras.java @@ -30,7 +30,7 @@ import java.util.Objects; /** Additional features added to CodeMirror by Gerrit Code Review. */ public class Extras { static final native Extras get(CodeMirror c) /*-{ return c.gerritExtras }-*/; - private static final native void set(CodeMirror c, Extras e) + private static native void set(CodeMirror c, Extras e) /*-{ c.gerritExtras = e }-*/; static void attach(CodeMirror c) { diff --git a/gerrit-gwtui/src/main/java/net/codemirror/mode/ModeInfo.java b/gerrit-gwtui/src/main/java/net/codemirror/mode/ModeInfo.java index 9c82c0659e..697f4e1fdf 100644 --- a/gerrit-gwtui/src/main/java/net/codemirror/mode/ModeInfo.java +++ b/gerrit-gwtui/src/main/java/net/codemirror/mode/ModeInfo.java @@ -258,7 +258,7 @@ public class ModeInfo extends JavaScriptObject { public final native JsArrayString mimes() /*-{ return this.mimes || [this.mime] }-*/; - private final native JsArrayString ext() + private native JsArrayString ext() /*-{ return this.ext || [] }-*/; protected ModeInfo() { diff --git a/gerrit-plugin-gwtui/src/main/java/com/google/gerrit/plugin/client/Plugin.java b/gerrit-plugin-gwtui/src/main/java/com/google/gerrit/plugin/client/Plugin.java index f4f427be1e..8f38fac675 100644 --- a/gerrit-plugin-gwtui/src/main/java/com/google/gerrit/plugin/client/Plugin.java +++ b/gerrit-plugin-gwtui/src/main/java/com/google/gerrit/plugin/client/Plugin.java @@ -94,7 +94,7 @@ public final class Plugin extends JavaScriptObject { screen(token, wrap(entry)); } - private final native void screen(String t, JavaScriptObject e) + private native void screen(String t, JavaScriptObject e) /*-{ this.screen(t, e) }-*/; /** @@ -109,7 +109,7 @@ public final class Plugin extends JavaScriptObject { screenRegex(regex, wrap(entry)); } - private final native void screenRegex(String p, JavaScriptObject e) + private native void screenRegex(String p, JavaScriptObject e) /*-{ this.screen(new $wnd.RegExp(p), e) }-*/; /** @@ -122,7 +122,7 @@ public final class Plugin extends JavaScriptObject { settingsScreen(token, menu, wrap(entry)); } - private final native void settingsScreen(String t, String m, JavaScriptObject e) + private native void settingsScreen(String t, String m, JavaScriptObject e) /*-{ this.settingsScreen(t, m, e) }-*/; /** @@ -136,7 +136,7 @@ public final class Plugin extends JavaScriptObject { panel(extensionPoint.name(), wrap(entry)); } - private final native void panel(String i, JavaScriptObject e) + private native void panel(String i, JavaScriptObject e) /*-{ this.panel(i, e) }-*/; protected Plugin() { @@ -144,17 +144,17 @@ public final class Plugin extends JavaScriptObject { native void _initialized() /*-{ this._success = true }-*/; native void _loaded() /*-{ this._loadedGwt() }-*/; - private static final native Plugin install(String u) + private static native Plugin install(String u) /*-{ return $wnd.Gerrit.installGwt(u) }-*/; - private static final native JavaScriptObject wrap(Screen.EntryPoint b) /*-{ + private static native JavaScriptObject wrap(Screen.EntryPoint b) /*-{ return $entry(function(c){ b.@com.google.gerrit.plugin.client.screen.Screen.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/screen/Screen;)( @com.google.gerrit.plugin.client.screen.Screen::new(Lcom/google/gerrit/plugin/client/screen/Screen$Context;)(c)); }); }-*/; - private static final native JavaScriptObject wrap(Panel.EntryPoint b) /*-{ + private static native JavaScriptObject wrap(Panel.EntryPoint b) /*-{ return $entry(function(c){ b.@com.google.gerrit.plugin.client.extension.Panel.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/extension/Panel;)( @com.google.gerrit.plugin.client.extension.Panel::new(Lcom/google/gerrit/plugin/client/extension/Panel$Context;)(c));