opendev/gerrit
Code Issues Proposed changes

Metadata: Rename noteDbFileName to noteDbFilePath

Browse Source 
It's the full path that is stored in this field. Make this clearer by
the field name.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ic8b60468c6f9f1a16734e18d15fa0d9bddb8980c
This commit is contained in:
Edwin Kempin
2019-07-15 09:03:46 +02:00
parent a02aa0ac5d
commit e017a1fe4c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/com/google/gerrit/server/git/meta/VersionedMetaData.java
View File

@@ -505,7 +505,7 @@ public abstract class VersionedMetaData {
.projectName(projectName.get()) .projectName(projectName.get())
.noteDbRefName(getRefName()) .noteDbRefName(getRefName())
.revision(revision.name()) .revision(revision.name())
.noteDbFileName(fileName) .noteDbFilePath(fileName)
.build()); .build());
TreeWalk tw = TreeWalk.forPath(reader, fileName, revision.getTree())) { TreeWalk tw = TreeWalk.forPath(reader, fileName, revision.getTree())) {
if (tw != null) { if (tw != null) {
@@ -585,7 +585,7 @@ public abstract class VersionedMetaData {
Metadata.builder() Metadata.builder()
.projectName(projectName.get()) .projectName(projectName.get())
.noteDbRefName(getRefName()) .noteDbRefName(getRefName())
.noteDbFileName(fileName) .noteDbFilePath(fileName)
.build())) { .build())) {
DirCacheEditor editor = newTree.editor(); DirCacheEditor editor = newTree.editor();
if (raw != null && 0 < raw.length) { if (raw != null && 0 < raw.length) {

6
java/com/google/gerrit/server/logging/Metadata.java
View File

@@ -86,8 +86,8 @@ public abstract class Metadata {
// Boolean: one or more // Boolean: one or more
public abstract Optional<Boolean> multiple(); public abstract Optional<Boolean> multiple();
// Name of a metadata file in NoteDb. // Path of a metadata file in NoteDb.
public abstract Optional<String> noteDbFileName(); public abstract Optional<String> noteDbFilePath();
// Name of a metadata ref in NoteDb. // Name of a metadata ref in NoteDb.
public abstract Optional<String> noteDbRefName(); public abstract Optional<String> noteDbRefName();
@@ -174,7 +174,7 @@ public abstract class Metadata {
public abstract Builder multiple(boolean multiple); public abstract Builder multiple(boolean multiple);
public abstract Builder noteDbFileName(@Nullable String noteDbFileName); public abstract Builder noteDbFilePath(@Nullable String noteDbFilePath);
public abstract Builder noteDbRefName(@Nullable String noteDbRefName); public abstract Builder noteDbRefName(@Nullable String noteDbRefName);