opendev/gerrit
Code Issues Proposed changes

Add /config/check.access endpoint

Browse Source 
The check.access endpoint is for administrative users. It can be
supplied with a (project, account) or (project, account, ref) tuple to
check that ACLs are behaving as expected.

Change-Id: Icf74b0fc4036312eef9f222aaff8e1769a051eec
This commit is contained in:
Han-Wen Nienhuys
2017-04-25 17:41:58 +02:00
parent 5646393ac7
commit e04df7e589
8 changed files with 433 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
gerrit-server/src/main/java/com/google/gerrit/server/api/config/ServerImpl.java
View File

@@ -15,6 +15,8 @@
package com.google.gerrit.server.api.config;
import com.google.gerrit.common.Version;
import com.google.gerrit.extensions.api.config.AccessCheckInfo;
import com.google.gerrit.extensions.api.config.AccessCheckInput;
import com.google.gerrit.extensions.api.config.ConsistencyCheckInfo;
import com.google.gerrit.extensions.api.config.ConsistencyCheckInput;
import com.google.gerrit.extensions.api.config.Server;
@@ -22,6 +24,7 @@ import com.google.gerrit.extensions.client.DiffPreferencesInfo;
import com.google.gerrit.extensions.client.GeneralPreferencesInfo;
import com.google.gerrit.extensions.common.ServerInfo;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.server.config.CheckAccess;
import com.google.gerrit.server.config.CheckConsistency;
import com.google.gerrit.server.config.ConfigResource;
import com.google.gerrit.server.config.GetDiffPreferences;
@@ -29,6 +32,8 @@ import com.google.gerrit.server.config.GetPreferences;
import com.google.gerrit.server.config.GetServerInfo;
import com.google.gerrit.server.config.SetDiffPreferences;
import com.google.gerrit.server.config.SetPreferences;
import com.google.gerrit.server.permissions.PermissionBackendException;
import com.google.gwtorm.server.Access;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.Singleton;
@@ -43,6 +48,7 @@ public class ServerImpl implements Server {
private final SetDiffPreferences setDiffPreferences;
private final GetServerInfo getServerInfo;
private final Provider<CheckConsistency> checkConsistency;
private final Provider<CheckAccess> checkAccess;
@Inject
ServerImpl(
@@ -51,13 +57,15 @@ public class ServerImpl implements Server {
GetDiffPreferences getDiffPreferences,
SetDiffPreferences setDiffPreferences,
GetServerInfo getServerInfo,
Provider<CheckConsistency> checkConsistency) {
Provider<CheckConsistency> checkConsistency,
Provider<CheckAccess> checkAccess) {
this.getPreferences = getPreferences;
this.setPreferences = setPreferences;
this.getDiffPreferences = getDiffPreferences;
this.setDiffPreferences = setDiffPreferences;
this.getServerInfo = getServerInfo;
this.checkConsistency = checkConsistency;
this.checkAccess = checkAccess;
}
@Override
@@ -120,4 +128,13 @@ public class ServerImpl implements Server {
throw new RestApiException("Cannot check consistency", e);
}
}
@Override
public AccessCheckInfo checkAccess(AccessCheckInput in) throws RestApiException {
try {
return checkAccess.get().apply(new ConfigResource(), in);
} catch (IOException | PermissionBackendException e) {
throw new RestApiException("Cannot check access", e);
}
}
}