opendev/gerrit
Code Issues Proposed changes

Move footer links and rename them to Old UI/New UI

Browse Source 
+ Users don’t know what PolyGerrit is, so this changes makes the
  links more explicit.
+ Placing the Report Bug and Old UI links on the right side avoids
  the anchor popup in Chrome obscuring the text itself.

Bug: Issue 5241
Change-Id: I1eab389cc311df786e21553c1869c4453aa3685d
This commit is contained in:
Andrew Bonventre
2017-01-10 11:59:13 -08:00
parent 87cb82f5a1
commit e0674b6852
4 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
polygerrit-ui/app/elements/gr-app.html
View File

@@ -54,6 +54,8 @@ limitations under the License.
}
footer {
background-color: var(--footer-background-color, #eee);
display: flex;
justify-content: space-between;
padding: .5rem var(--default-horizontal-margin);
}
main {
@@ -128,17 +130,20 @@ limitations under the License.
</div>
</main>
<footer role="contentinfo">
Powered by <a href="https://www.gerritcodereview.com/" rel="noopener"
target="_blank">Gerrit Code Review</a>
([[_version]])
|
<a class="feedback"
href="https://bugs.chromium.org/p/gerrit/issues/entry?template=PolyGerrit%20Issue"
rel="noopener" target="_blank">Report PolyGerrit Bug</a>
<template is="dom-if" if="[[_computeShowGwtUiLink(_serverConfig)]]">
|
<a id="gwtLink" href$="/?polygerrit=0#[[_path]]" rel="external">GWT UI</a>
</template>
<div>
Powered by <a href="https://www.gerritcodereview.com/" rel="noopener"
target="_blank">Gerrit Code Review</a>
([[_version]])
</div>
<div>
<a class="feedback"
href="https://bugs.chromium.org/p/gerrit/issues/entry?template=PolyGerrit%20Issue"
rel="noopener" target="_blank">Report bug</a>
<template is="dom-if" if="[[_computeShowGwtUiLink(_serverConfig)]]">
|
<a id="gwtLink" href$="/?polygerrit=0#[[_path]]" rel="external">Old UI</a>
</template>
</div>
</footer>
<gr-overlay id="keyboardShortcuts" with-backdrop>
<gr-keyboard-shortcuts-dialog