opendev/gerrit
Code Issues Proposed changes

Remove command line reviewer/cc visibility check

Browse Source 
This differs from the behavior of %r= in the magic branch or even
the new push option support of "-o r=". Drop the visibility check
here and just pass down the identities to ReceiveCommits so that
behavior is consistent.

Change-Id: Iabec4d5c48afd4e820d6bd824c6ae24b0a1e37b5
This commit is contained in:
Shawn Pearce 2017-02-22 16:42:11 -08:00
parent 493be51816
commit e0774b74d4
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/Receive.java
View File

@ -49,11 +49,7 @@ final class Receive extends AbstractGitCommand {
private static final Logger log = LoggerFactory.getLogger(Receive.class);
@Inject private AsyncReceiveCommits.Factory factory;
@Inject private IdentifiedUser currentUser;
@Inject private IdentifiedUser.GenericFactory identifiedUserFactory;
@Inject private SshSession session;
private final Set<Account.Id> reviewerId = new HashSet<>();
@ -92,9 +88,6 @@ final class Receive extends AbstractGitCommand {
throw die(r.getMessage());
}
verifyProjectVisible("reviewer", reviewerId);
verifyProjectVisible("CC", ccId);
receive.init();
receive.addReviewers(reviewerId);
receive.addExtraCC(ccId);
@ -172,14 +165,4 @@ final class Receive extends AbstractGitCommand {
throw new Failure(128, "fatal: Unpack error, check server log", detail);
}
}
private void verifyProjectVisible(final String type, final Set<Account.Id> who)
throws UnloggedFailure {
for (final Account.Id id : who) {
final IdentifiedUser user = identifiedUserFactory.create(id);
if (!projectControl.forUser(user).isVisible()) {
throw die(type + " " + user.getAccount().getFullName() + " cannot access the project");
}
}
}
}