opendev/gerrit
Code Issues Proposed changes

Label: Make the meaning of the blank cell visible

Browse Source 
On changes dashboard the label columns often have some blank cells
especially when user has some customized label for some special branch.

  [1] some of them mean for current change this label is not applicable.
  [2] some of them mean this label is applied on this change's branch but
      this change has not got any vote on this label yet.

In order to figure out what a blank cell means, a user has to click that row
to open the ChangeScreen and check the approval table.

This commit makes it easy to distinguish these blank cells by setting
blank cells matching case [1] to display grey background and have a title
'Label not applicable'.

Even for the case where all labels are project-specific, this feature is
valuable.

Change-Id: Ic965ad51f60919ecf1d3cefb9456271950d51302
This commit is contained in:
Bruce Zu 2013-07-29 15:23:09 +08:00
parent 90245f8810
commit e0ebc492cc
5 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritConstants.java
View File

@ -48,6 +48,8 @@ public interface GerritConstants extends Constants {
String inactiveAccountBody(); String inactiveAccountBody();
String labelNotApplicable();
String menuAll(); String menuAll();
String menuAllOpen(); String menuAllOpen();
String menuAllMerged(); String menuAllMerged();

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritConstants.properties
View File

@ -31,6 +31,8 @@ noSuchGroupTitle = Code Review - Unknown Group
inactiveAccountBody = This user is currently inactive. inactiveAccountBody = This user is currently inactive.
labelNotApplicable = Label not applicable
menuAll = All menuAll = All
menuAllOpen = Open menuAllOpen = Open
menuAllMerged = Merged menuAllMerged = Merged

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritCss.java
View File

@ -141,6 +141,7 @@ public interface GerritCss extends CssResource {
String infoTable(); String infoTable();
String inputFieldTypeHint(); String inputFieldTypeHint();
String labelList(); String labelList();
String labelNotApplicable();
String leftMostCell(); String leftMostCell();
String lineHeader(); String lineHeader();
String lineNumber(); String lineNumber();

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable2.java
View File

@ -230,7 +230,8 @@ public class ChangeTable2 extends NavigationTable<ChangeInfo> {
LabelInfo label = c.label(name); LabelInfo label = c.label(name);
if (label == null) { if (label == null) {
table.clearCell(row, col); fmt.getElement(row, col).setTitle(Gerrit.C.labelNotApplicable());
fmt.addStyleName(row, col, Gerrit.RESOURCES.css().labelNotApplicable());
continue; continue;
} }

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css
View File

@ -595,6 +595,9 @@ a:hover {
.changeTable .dataCell.singleLine { .changeTable .dataCell.singleLine {
white-space: nowrap; white-space: nowrap;
} }
.changeTable .dataCell.labelNotApplicable {
background: #F5F5F5;
}
.changeTable .iconHeader { .changeTable .iconHeader {
border-top: 1px solid backgroundColor; border-top: 1px solid backgroundColor;
border-bottom: 1px solid backgroundColor; border-bottom: 1px solid backgroundColor;