opendev/gerrit
Code Issues Proposed changes

Merge "Fix authentication exception for list comments with anonymous users"

Browse Source
This commit is contained in:
Youssef Elghareeb
2020-04-07 16:50:41 +00:00
committed by Gerrit Code Review
parent d0ba502f27 3e4b34b466
commit e16907226b
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
java/com/google/gerrit/server/restapi/change/ListChangeComments.java
View File

@@ -57,17 +57,12 @@ public class ListChangeComments implements RestReadView<ChangeResource> {
@Override
public Response<Map<String, List<CommentInfo>>> apply(ChangeResource rsrc)
throws AuthException, PermissionBackendException {
if (!rsrc.getUser().isIdentifiedUser()) {
throw new AuthException("Authentication required");
}
/** List change comments does not require authentication */
return Response.ok(getAsMap(listComments(rsrc), rsrc));
}
public List<CommentInfo> getComments(ChangeResource rsrc)
throws AuthException, PermissionBackendException {
if (!rsrc.getUser().isIdentifiedUser()) {
throw new AuthException("Authentication required");
}
public List<CommentInfo> getComments(ChangeResource rsrc) throws PermissionBackendException {
/** List change comments does not require authentication */
return getAsList(listComments(rsrc), rsrc);
}