opendev/gerrit
Code Issues Proposed changes

Add abstract methods to the ChangeEvent hierarchy

Browse Source 
There is some common information in the ChangeEvent hierarchy, such as
the type string, the change, and the project, that is not expressed in
the old POJO hierarchy. Add a few convenience methods that can be used
if the user has just a ChangeEvent, but which do not affect the JSON
serialization.

Change-Id: I22aadf76835528a63743bd758b5d6868dad212ed
This commit is contained in:
Dave Borowitz
2014-10-09 14:30:28 -04:00
committed by Simon Lei
parent 8dc720ed9b
commit e172f777b2
14 changed files with 354 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
gerrit-server/src/main/java/com/google/gerrit/server/events/CommentAddedEvent.java
View File

@@ -14,16 +14,40 @@
package com.google.gerrit.server.events;
import static org.eclipse.jgit.lib.Constants.R_HEADS;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.server.data.AccountAttribute;
import com.google.gerrit.server.data.ApprovalAttribute;
import com.google.gerrit.server.data.ChangeAttribute;
import com.google.gerrit.server.data.PatchSetAttribute;
public class CommentAddedEvent extends ChangeEvent {
public final String type = "comment-added";
public ChangeAttribute change;
public PatchSetAttribute patchSet;
public AccountAttribute author;
public ApprovalAttribute[] approvals;
public String comment;
public final String type = "comment-added";
public ChangeAttribute change;
public PatchSetAttribute patchSet;
public AccountAttribute author;
public ApprovalAttribute[] approvals;
public String comment;
@Override
public String getType() {
return type;
}
@Override
public Project.NameKey getProjectNameKey() {
return new Project.NameKey(change.project);
}
@Override
public Change.Key getChangeKey() {
return new Change.Key(change.id);
}
@Override
public String getRefName() {
return R_HEADS + change.branch;
}
}