Revert "Remove usage of to-be-deprecated Throwables"

Guava snapshot is gone.

This reverts commit 8df8a2489d.

Change-Id: I1f6f40a824e39240d67da9b305bdc8144505e7bf
This commit is contained in:
Dave Borowitz
2016-08-25 00:04:52 +00:00
committed by Jonathan Nieder
parent 5ae08a229f
commit e1767e5ad7
17 changed files with 21 additions and 21 deletions

View File

@@ -377,7 +377,7 @@ public class LuceneChangeIndex implements ChangeIndex {
close(); close();
throw new OrmRuntimeException(e); throw new OrmRuntimeException(e);
} catch (ExecutionException e) { } catch (ExecutionException e) {
Throwables.throwIfUnchecked(e.getCause()); Throwables.propagateIfPossible(e.getCause());
throw new OrmRuntimeException(e.getCause()); throw new OrmRuntimeException(e.getCause());
} }
} }

View File

@@ -94,7 +94,7 @@ public class AccountLoader {
directory.fillAccountInfo( directory.fillAccountInfo(
Iterables.concat(created.values(), provided), options); Iterables.concat(created.values(), provided), options);
} catch (DirectoryException e) { } catch (DirectoryException e) {
Throwables.throwIfInstanceOf(e.getCause(), OrmException.class); Throwables.propagateIfPossible(e.getCause(), OrmException.class);
throw new OrmException(e); throw new OrmException(e);
} }
} }

View File

@@ -47,7 +47,7 @@ public class GetDetail implements RestReadView<AccountResource> {
directory.fillAccountInfo(Collections.singleton(info), directory.fillAccountInfo(Collections.singleton(info),
EnumSet.allOf(FillOptions.class)); EnumSet.allOf(FillOptions.class));
} catch (DirectoryException e) { } catch (DirectoryException e) {
Throwables.throwIfInstanceOf(e.getCause(), OrmException.class); Throwables.propagateIfPossible(e.getCause(), OrmException.class);
throw new OrmException(e); throw new OrmException(e);
} }
return info; return info;

View File

@@ -154,8 +154,8 @@ import javax.security.auth.login.LoginException;
} }
}); });
} catch (PrivilegedActionException e) { } catch (PrivilegedActionException e) {
Throwables.throwIfInstanceOf(e.getException(), NamingException.class); Throwables.propagateIfPossible(e.getException(), NamingException.class);
Throwables.throwIfInstanceOf(e.getException(), RuntimeException.class); Throwables.propagateIfPossible(e.getException(), RuntimeException.class);
LdapRealm.log.warn("Internal error", e.getException()); LdapRealm.log.warn("Internal error", e.getException());
return null; return null;
} finally { } finally {

View File

@@ -267,7 +267,7 @@ public class ChangeJson {
} catch (PatchListNotAvailableException | GpgException | OrmException } catch (PatchListNotAvailableException | GpgException | OrmException
| IOException | RuntimeException e) { | IOException | RuntimeException e) {
if (!has(CHECK)) { if (!has(CHECK)) {
Throwables.throwIfInstanceOf(e, OrmException.class); Throwables.propagateIfPossible(e, OrmException.class);
throw new OrmException(e); throw new OrmException(e);
} }
return checkOnly(cd); return checkOnly(cd);

View File

@@ -464,7 +464,7 @@ public class BatchUpdate implements AutoCloseable {
throw new ResourceNotFoundException(e.getMessage(), e); throw new ResourceNotFoundException(e.getMessage(), e);
} catch (Exception e) { } catch (Exception e) {
Throwables.throwIfUnchecked(e); Throwables.propagateIfPossible(e);
throw new UpdateException(e); throw new UpdateException(e);
} }
} }
@@ -669,7 +669,7 @@ public class BatchUpdate implements AutoCloseable {
logDebug("No objects to flush"); logDebug("No objects to flush");
} }
} catch (Exception e) { } catch (Exception e) {
Throwables.throwIfInstanceOf(e, RestApiException.class); Throwables.propagateIfPossible(e, RestApiException.class);
throw new UpdateException(e); throw new UpdateException(e);
} }
} }
@@ -744,8 +744,8 @@ public class BatchUpdate implements AutoCloseable {
maybeLogSlowUpdate(startNanos, "NoteDb"); maybeLogSlowUpdate(startNanos, "NoteDb");
} }
} catch (ExecutionException | InterruptedException e) { } catch (ExecutionException | InterruptedException e) {
Throwables.throwIfInstanceOf(e.getCause(), UpdateException.class); Throwables.propagateIfInstanceOf(e.getCause(), UpdateException.class);
Throwables.throwIfInstanceOf(e.getCause(), RestApiException.class); Throwables.propagateIfInstanceOf(e.getCause(), RestApiException.class);
throw new UpdateException(e); throw new UpdateException(e);
} catch (OrmException | IOException e) { } catch (OrmException | IOException e) {
throw new UpdateException(e); throw new UpdateException(e);

View File

@@ -197,7 +197,7 @@ public class RepoSequence {
limit = counter + count; limit = counter + count;
acquireCount++; acquireCount++;
} catch (ExecutionException | RetryException e) { } catch (ExecutionException | RetryException e) {
Throwables.throwIfInstanceOf(e.getCause(), OrmException.class); Throwables.propagateIfInstanceOf(e.getCause(), OrmException.class);
throw new OrmException(e); throw new OrmException(e);
} catch (IOException e) { } catch (IOException e) {
throw new OrmException(e); throw new OrmException(e);

View File

@@ -93,7 +93,7 @@ class IntraLineLoader implements Callable<IntraLineDiff> {
} catch (ExecutionException e) { } catch (ExecutionException e) {
// If there was an error computing the result, carry it // If there was an error computing the result, carry it
// up to the caller so the cache knows this key is invalid. // up to the caller so the cache knows this key is invalid.
Throwables.throwIfInstanceOf(e.getCause(), Exception.class); Throwables.propagateIfInstanceOf(e.getCause(), Exception.class);
throw new Exception(e.getMessage(), e.getCause()); throw new Exception(e.getMessage(), e.getCause());
} }
} }

View File

@@ -260,7 +260,7 @@ public class PatchListLoader implements Callable<PatchList> {
} catch (ExecutionException e) { } catch (ExecutionException e) {
// If there was an error computing the result, carry it // If there was an error computing the result, carry it
// up to the caller so the cache knows this key is invalid. // up to the caller so the cache knows this key is invalid.
Throwables.throwIfInstanceOf(e.getCause(), IOException.class); Throwables.propagateIfInstanceOf(e.getCause(), IOException.class);
throw new IOException(e.getMessage(), e.getCause()); throw new IOException(e.getMessage(), e.getCause());
} }
} }

View File

@@ -148,7 +148,7 @@ public class ProjectCacheImpl implements ProjectCache {
} catch (ExecutionException e) { } catch (ExecutionException e) {
if (!(e.getCause() instanceof RepositoryNotFoundException)) { if (!(e.getCause() instanceof RepositoryNotFoundException)) {
log.warn(String.format("Cannot read project %s", projectName.get()), e); log.warn(String.format("Cannot read project %s", projectName.get()), e);
Throwables.throwIfInstanceOf(e.getCause(), IOException.class); Throwables.propagateIfInstanceOf(e.getCause(), IOException.class);
throw new IOException(e); throw new IOException(e);
} }
return null; return null;

View File

@@ -49,7 +49,7 @@ public class RefPattern {
try { try {
return exampleCache.get(refPattern); return exampleCache.get(refPattern);
} catch (ExecutionException e) { } catch (ExecutionException e) {
Throwables.throwIfUnchecked(e.getCause()); Throwables.propagateIfPossible(e.getCause());
throw new RuntimeException(e); throw new RuntimeException(e);
} }
} else if (refPattern.endsWith("/*")) { } else if (refPattern.endsWith("/*")) {

View File

@@ -84,7 +84,7 @@ public class AndSource<T> extends AndPredicate<T>
try { try {
return readImpl(); return readImpl();
} catch (OrmRuntimeException err) { } catch (OrmRuntimeException err) {
Throwables.throwIfInstanceOf(err.getCause(), OrmException.class); Throwables.propagateIfInstanceOf(err.getCause(), OrmException.class);
throw new OrmException(err); throw new OrmException(err);
} }
} }

View File

@@ -140,7 +140,7 @@ public abstract class QueryProcessor<T> {
} catch (OrmRuntimeException e) { } catch (OrmRuntimeException e) {
throw new OrmException(e.getMessage(), e); throw new OrmException(e.getMessage(), e);
} catch (OrmException e) { } catch (OrmException e) {
Throwables.throwIfInstanceOf(e.getCause(), QueryParseException.class); Throwables.propagateIfInstanceOf(e.getCause(), QueryParseException.class);
throw e; throw e;
} }
} }

View File

@@ -129,7 +129,7 @@ public abstract class RequestScopePropagator {
try { try {
wrapped.call(); wrapped.call();
} catch (Exception e) { } catch (Exception e) {
Throwables.throwIfUnchecked(e); Throwables.propagateIfPossible(e);
throw new RuntimeException(e); // Not possible. throw new RuntimeException(e); // Not possible.
} }
} }

View File

@@ -97,7 +97,7 @@ public class AliasCommand extends BaseCommand {
try { try {
cmd.destroy(); cmd.destroy();
} catch (Exception e) { } catch (Exception e) {
Throwables.throwIfUnchecked(e); Throwables.propagateIfPossible(e);
throw new RuntimeException(e); throw new RuntimeException(e);
} }
} }

View File

@@ -136,7 +136,7 @@ final class DispatchCommand extends BaseCommand {
try { try {
cmd.destroy(); cmd.destroy();
} catch (Exception e) { } catch (Exception e) {
Throwables.throwIfUnchecked(e); Throwables.propagateIfPossible(e);
throw new RuntimeException(e); throw new RuntimeException(e);
} }
} }

View File

@@ -153,7 +153,7 @@ public final class SuExec extends BaseCommand {
try { try {
cmd.destroy(); cmd.destroy();
} catch (Exception e) { } catch (Exception e) {
Throwables.throwIfUnchecked(e); Throwables.propagateIfPossible(e);
throw new RuntimeException(e); throw new RuntimeException(e);
} }
} }