opendev/gerrit
Code Issues Proposed changes

Merge "Set commit ID in result of the /changes/*/revisions/*/commit endpoint"

Browse Source
This commit is contained in:
Edwin Kempin 2015-08-04 12:50:42 +00:00 committed by Gerrit Code Review
commit e1a0aa2e11
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Documentation/rest-api-changes.txt
View File

@ -2239,6 +2239,7 @@ describes the revision.
)]}'
{
"commit": "674ac754f91e64a0efb8087e59a176484bd534d1",
"parents": [
{
"commit": "1eee2c9d8f352483781e772f35dc586a69ff5646",
@ -3951,7 +3952,10 @@ The `CommitInfo` entity contains information about a commit.
[options="header",cols="1,^1,5"]
|===========================
|Field Name ||Description
|`commit` ||The commit ID.
|`commit` |Optional|
The commit ID. Not set if included in a link:#revision-info[
RevisionInfo] entity that is contained in a map which has the commit ID
as key.
|`parents` ||
The parent commits of this commit as a list of
link:#commit-info[CommitInfo] entities. In each parent

1
gerrit-server/src/main/java/com/google/gerrit/server/change/GetCommit.java
View File

@ -54,6 +54,7 @@ public class GetCommit implements RestReadView<RevisionResource> {
rw.parseBody(commit);
CommitInfo info = json.create(ChangeJson.NO_OPTIONS)
.toCommit(rsrc.getControl(), rw, commit, addLinks);
info.commit = commit.name();
Response<CommitInfo> r = Response.ok(info);
if (rsrc.isCacheable()) {
r.caching(CacheControl.PRIVATE(7, TimeUnit.DAYS));