opendev/gerrit
Code Issues Proposed changes

Kill @Rewrite support in queries

Browse Source 
These had been significantly pared down since almost all queries of
consequence are sent as-is to the secondary index subsystem. The
remaining queries just existed to simplify some arbitrary subtrees
into slightly less complicated subtrees. This required almost a
thousand lines of magical supporting code for something with no
remaining performance benefit. Let it die a graceful death.

Change-Id: I99ee92549b6619e7aa7529875149073f55c85c69
This commit is contained in:
Dave Borowitz
2015-05-26 18:05:05 -07:00
parent 78279ba1c7
commit e23ea2c7b9
10 changed files with 4 additions and 856 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-antlr/src/main/antlr3/com/google/gerrit/server/query/Query.g
View File

@@ -116,7 +116,6 @@ conditionAnd2
conditionNot
: '-' conditionBase -> ^(NOT conditionBase)
| NOT^ conditionBase
| VARIABLE_ASSIGN^ conditionOr ')'!
| conditionBase
;
conditionBase
@@ -143,13 +142,6 @@ FIELD_NAME
: ('a'..'z' | '_')+
;
VARIABLE_ASSIGN
: ('A'..'Z') ('A'..'Z' | 'a'..'Z')* '=' '(' {
String s = $text;
setText(s.substring(0, s.length() - 2));
}
;
EXACT_PHRASE
: '"' ( ~('"') )* '"' {
String s = $text;