opendev/gerrit
Code Issues Proposed changes

Remove all usage of Gerrit.FireBehavior

Browse Source 
After replaced all 'fire' with 'dispatchEvent',
this behavior is no longer needed.

Still kept the FireBehavior.js for backward compatbility for now.

Change-Id: Iddeba33b46c03e4ec077374a66126b24e9656787
This commit is contained in:
Tao Zhou
2020-04-14 12:25:25 +02:00
parent e6878b47f2
commit e25546a31b
70 changed files with 58 additions and 299 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js
View File

@@ -23,7 +23,6 @@ import '../../../styles/shared-styles.js';
import '../../shared/gr-autocomplete/gr-autocomplete.js';
import '../../shared/gr-dialog/gr-dialog.js';
import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
import {mixinBehaviors} from '@polymer/polymer/lib/legacy/class.js';
import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js';
import {LegacyElementMixin} from '@polymer/polymer/lib/legacy/legacy-element-mixin.js';
import {PolymerElement} from '@polymer/polymer/polymer-element.js';
@@ -32,14 +31,10 @@ import {htmlTemplate} from './gr-confirm-cherrypick-dialog_html.js';
const SUGGESTIONS_LIMIT = 15;
/**
* @appliesMixin Gerrit.FireMixin
* @extends Polymer.Element
*/
class GrConfirmCherrypickDialog extends mixinBehaviors( [
Gerrit.FireBehavior,
], GestureEventListeners(
LegacyElementMixin(
PolymerElement))) {
class GrConfirmCherrypickDialog extends GestureEventListeners(
LegacyElementMixin(PolymerElement)) {
static get template() { return htmlTemplate; }
static get is() { return 'gr-confirm-cherrypick-dialog'; }