diff --git a/Documentation/dev-plugins.txt b/Documentation/dev-plugins.txt index 13b6978c48..e61a725e8b 100644 --- a/Documentation/dev-plugins.txt +++ b/Documentation/dev-plugins.txt @@ -1200,20 +1200,16 @@ public Object apply(RevisionResource rcrs, Input in) { [...] // update change ReviewDb db = dbProvider.get(); - db.changes().beginTransaction(change.getId()); - try { - change = db.changes().atomicUpdate( - change.getId(), - new AtomicUpdate() { - @Override - public Change update(Change change) { - ChangeUtil.updated(change); - return change; - } - }); - db.commit(); - } finally { - db.rollback(); + try (BatchUpdate bu = batchUpdateFactory.create( + db, project.getNameKey(), user, TimeUtil.nowTs())) { + bu.addOp(change.getId(), new BatchUpdate.Op() { + @Override + public boolean updateChange(BatchUpdate.ChangeContext ctx) { + ctx.saveChange(); + return true; + } + }); + bu.execute(); } [...] } diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java index bf93329abf..b694cd825a 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java @@ -16,7 +16,6 @@ package com.google.gerrit.server; import com.google.common.base.Function; import com.google.common.collect.Ordering; -import com.google.gerrit.common.TimeUtil; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.server.ReviewDb; @@ -87,10 +86,6 @@ public class ChangeUtil { } } - public static void updated(Change c) { - c.setLastUpdatedOn(TimeUtil.nowTs()); - } - public static PatchSet.Id nextPatchSetId(Map allRefs, PatchSet.Id id) { PatchSet.Id next = nextPatchSetId(id);