opendev/gerrit
Code Issues Proposed changes

Get{Email|Username}: Add back empty @Inject constructors

Browse Source 
In changes Ie7a57ba94 and Ia4cd7ff10 the constructors were
removed, however according to the commit message in [1], we
don't want the implicit public no-args constructors; callers
should use Guice to get instances.

Add back the removed constructors.

[1] https://gerrit-review.googlesource.com/#/c/73864/1

Change-Id: Ifb4085534d5ec62f52dcc3621e735fbd444ba6f0
This commit is contained in:
David Pursehouse 2016-01-14 10:55:54 +09:00
parent dbe8de6a50
commit e33a3f43df
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-server/src/main/java/com/google/gerrit/server/account/GetEmail.java
View File

@ -16,10 +16,15 @@ package com.google.gerrit.server.account;
import com.google.gerrit.extensions.restapi.RestReadView; import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.gerrit.server.account.GetEmails.EmailInfo; import com.google.gerrit.server.account.GetEmails.EmailInfo;
import com.google.inject.Inject;
import com.google.inject.Singleton; import com.google.inject.Singleton;
@Singleton @Singleton
public class GetEmail implements RestReadView<AccountResource.Email> { public class GetEmail implements RestReadView<AccountResource.Email> {
@Inject
public GetEmail() {
}
@Override @Override
public EmailInfo apply(AccountResource.Email rsrc) { public EmailInfo apply(AccountResource.Email rsrc) {
EmailInfo e = new EmailInfo(); EmailInfo e = new EmailInfo();

4
gerrit-server/src/main/java/com/google/gerrit/server/account/GetUsername.java
View File

@ -17,10 +17,14 @@ package com.google.gerrit.server.account;
import com.google.gerrit.extensions.restapi.AuthException; import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.ResourceNotFoundException; import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
import com.google.gerrit.extensions.restapi.RestReadView; import com.google.gerrit.extensions.restapi.RestReadView;
import com.google.inject.Inject;
import com.google.inject.Singleton; import com.google.inject.Singleton;
@Singleton @Singleton
public class GetUsername implements RestReadView<AccountResource> { public class GetUsername implements RestReadView<AccountResource> {
@Inject
public GetUsername() {
}
@Override @Override
public String apply(AccountResource rsrc) throws AuthException, public String apply(AccountResource rsrc) throws AuthException,