From 41eae482e8bae729032a0b88eab93836484b524a Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Fri, 10 Jan 2020 20:31:10 +0100 Subject: [PATCH] Fix eclipse project generation In Ibe62917e20 maven jar merging using python was replaced with java_binary rule. Fix eclipse project generation and also clean up left over unused import statement and script. Change-Id: I46b14f8e8e380f38962937be253fb1b7e4fa147d --- lib/lucene/BUILD | 1 - tools/bzl/maven.bzl | 34 ---------------------------------- tools/eclipse/project.py | 4 ++-- 3 files changed, 2 insertions(+), 37 deletions(-) delete mode 100644 tools/bzl/maven.bzl diff --git a/lib/lucene/BUILD b/lib/lucene/BUILD index 5ca9580f09..93eeccb319 100644 --- a/lib/lucene/BUILD +++ b/lib/lucene/BUILD @@ -1,5 +1,4 @@ load("@rules_java//java:defs.bzl", "java_binary", "java_import", "java_library") -load("//tools/bzl:maven.bzl", "merge_maven_jars") package(default_visibility = ["//visibility:public"]) diff --git a/tools/bzl/maven.bzl b/tools/bzl/maven.bzl deleted file mode 100644 index 36e3084e78..0000000000 --- a/tools/bzl/maven.bzl +++ /dev/null @@ -1,34 +0,0 @@ -# Copyright (C) 2016 The Android Open Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -# Merge maven files - -load("@rules_java//java:defs.bzl", "java_import") - -def cmd(jars): - return ("$(location //tools:merge_jars) $@ " + - " ".join(["$(location %s)" % j for j in jars])) - -def merge_maven_jars(name, srcs, **kwargs): - native.genrule( - name = "%s__merged_bin" % name, - cmd = cmd(srcs), - tools = srcs + ["//tools:merge_jars"], - outs = ["%s__merged.jar" % name], - ) - java_import( - name = name, - jars = [":%s__merged_bin" % name], - **kwargs - ) diff --git a/tools/eclipse/project.py b/tools/eclipse/project.py index 3c366c6de4..fe20331f3f 100755 --- a/tools/eclipse/project.py +++ b/tools/eclipse/project.py @@ -222,8 +222,8 @@ def gen_classpath(ext): # Exceptions: both source and lib if p.endswith('libquery_parser.jar') or \ p.endswith('libgerrit-prolog-common.jar') or \ - p.endswith('com_google_protobuf/libprotobuf_java.jar') or \ - p.endswith('lucene-core-and-backward-codecs__merged.jar'): + p.endswith('com_google_protobuf/libprotobuf_java.jar') or \ + p.endswith('lucene-core-and-backward-codecs-merged_deploy.jar'): lib.add(p) # JGit dependency from external repository if 'gerrit-' not in p and 'jgit' in p: